Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/frameworks/ember/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@
"prep": "jiti ../../../scripts/prepare/tsc.ts"
},
"dependencies": {
"@storybook/builder-webpack5": "workspace:*",
"@storybook/builder-webpack5": "6.2.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Replacing workspace:* with a pinned, much older version (6.2.0) for @storybook/builder-webpack5 is a critical issue. This package is part of a Yarn workspace monorepo, and this change breaks the linkage between packages within the repository. The current workspace version is 8.3.0-beta.3, so this is a major downgrade that will almost certainly cause build failures and runtime incompatibilities.

The correct way to fix the underlying security vulnerability is to update the dependencies of @storybook/builder-webpack5 or its transitive dependencies, not to downgrade the package itself. This change should be reverted.

Suggested change
"@storybook/builder-webpack5": "6.2.0",
"@storybook/builder-webpack5": "workspace:*",

"@storybook/global": "^5.0.0",
"babel-loader": "9.1.3",
"babel-loader": "10.0.0",
"find-up": "^5.0.0",
"ts-dedent": "^2.0.0"
},
Expand Down
Loading