Skip to content

[Snyk] Fix for 2 vulnerabilities#440

Open
q1blue wants to merge 1 commit intonextfrom
snyk-fix-9c97c9a909ea19e242ba1c1476cc796f
Open

[Snyk] Fix for 2 vulnerabilities#440
q1blue wants to merge 1 commit intonextfrom
snyk-fix-9c97c9a909ea19e242ba1c1476cc796f

Conversation

@q1blue
Copy link

@q1blue q1blue commented Feb 15, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/frameworks/ember/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  157  
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-15268416
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by resolving two critical vulnerabilities. It achieves this by updating key dependencies within the Ember framework's package.json, specifically targeting versions of @storybook/builder-webpack5 and babel-loader to mitigate the identified risks.

Highlights

  • Security Vulnerability Fixes: This PR addresses two identified vulnerabilities: a high-severity Regular Expression Denial of Service (ReDoS) (SNYK-JS-AJV-15274295) and a medium-severity Allocation of Resources Without Limits or Throttling (SNYK-JS-QS-15268416).
  • Dependency Updates: The package.json file for the Ember framework has been updated to upgrade @storybook/builder-webpack5 to 6.2.0 and babel-loader to 10.0.0.
Changelog
  • code/frameworks/ember/package.json
    • Updated @storybook/builder-webpack5 from workspace:* to 6.2.0.
    • Updated babel-loader from 9.1.3 to 10.0.0.
Activity
  • This pull request was automatically created by Snyk to fix identified vulnerabilities.
  • A warning is present indicating that yarn.lock failed to update and requires manual intervention.
  • Snyk has provided links to view the latest project report, customize PR templates, adjust project settings, and learn about Snyk's upgrade logic.
  • Interactive lessons for the fixed vulnerabilities (ReDoS and Allocation of Resources Without Limits or Throttling) are linked.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, attempts to fix two security vulnerabilities by updating dependencies. However, one of the changes is critical and will likely break the project.

  1. Critical Downgrade: The dependency @storybook/builder-webpack5 is changed from workspace:* to a hard-pinned, old version 6.2.0. This breaks the monorepo's workspace linking and will almost certainly lead to build failures or runtime errors due to the large version mismatch with other Storybook packages in the repository (which are at version 8.3.0-beta.3). This change should be reverted. The underlying vulnerability should be addressed by updating transitive dependencies within the monorepo, not by downgrading a core package.

  2. Missing yarn.lock: As noted in the PR description, the yarn.lock file has not been updated. Any dependency changes in package.json must be accompanied by a corresponding update to the lock file to ensure deterministic installs. The lock file must be generated and included in this PR before merging.

Due to the critical issue with the @storybook/builder-webpack5 downgrade, I recommend closing this PR and addressing the vulnerabilities manually by updating the correct packages within the monorepo structure.

},
"dependencies": {
"@storybook/builder-webpack5": "workspace:*",
"@storybook/builder-webpack5": "6.2.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Replacing workspace:* with a pinned, much older version (6.2.0) for @storybook/builder-webpack5 is a critical issue. This package is part of a Yarn workspace monorepo, and this change breaks the linkage between packages within the repository. The current workspace version is 8.3.0-beta.3, so this is a major downgrade that will almost certainly cause build failures and runtime incompatibilities.

The correct way to fix the underlying security vulnerability is to update the dependencies of @storybook/builder-webpack5 or its transitive dependencies, not to downgrade the package itself. This change should be reverted.

Suggested change
"@storybook/builder-webpack5": "6.2.0",
"@storybook/builder-webpack5": "workspace:*",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants