Skip to content

[Snyk] Fix for 2 vulnerabilities #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: next
Choose a base branch
from
Open

[Snyk] Fix for 2 vulnerabilities #435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions code/frameworks/html-webpack5/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@
"prep": "jiti ../../../scripts/prepare/bundle.ts"
},
"dependencies": {
"@storybook/builder-webpack5": "workspace:*",
"@storybook/builder-webpack5": "6.2.0",
"@storybook/global": "^5.0.0",
"@storybook/html": "workspace:*",
"@storybook/preset-html-webpack": "workspace:*",
"@storybook/preset-html-webpack": "7.0.0",
Comment on lines +50 to +53
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change from Snyk seems incorrect for this monorepo. It replaces workspace-local packages (workspace:*) with older, hardcoded versions from the public registry. This will likely break the project, as it's a major downgrade from the 8.3.0-beta.3 versions currently in the workspace.

Instead of downgrading these packages, the underlying vulnerabilities in ajv and qs should be addressed directly. A better approach would be to use Yarn's resolutions feature in the root package.json to force newer, non-vulnerable versions of these transitive dependencies across the entire workspace.

For example, you could add something like this to the root package.json:

"resolutions": {
  "ajv": "^6.12.6",
  "qs": "^6.11.2"
}

Please verify the correct non-vulnerable versions and apply this fix instead. This automated PR should be closed.

"@types/node": "^22.0.0"
},
"devDependencies": {
Expand Down
Loading