Skip to content

[Snyk] Fix for 2 vulnerabilities#435

Open
q1blue wants to merge 1 commit intonextfrom
snyk-fix-c0a273007f17bd30a40869237e03c555
Open

[Snyk] Fix for 2 vulnerabilities#435
q1blue wants to merge 1 commit intonextfrom
snyk-fix-c0a273007f17bd30a40869237e03c555

Conversation

@q1blue
Copy link

@q1blue q1blue commented Feb 14, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/frameworks/html-webpack5/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  803  
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-15268416
  708  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving two critical vulnerabilities within its yarn dependencies. The changes involve specific version upgrades for Storybook-related packages, directly mitigating the identified security risks.

Highlights

  • Security Vulnerability Fixes: This PR addresses two identified vulnerabilities: a high-severity Regular Expression Denial of Service (ReDoS) and a medium-severity Allocation of Resources Without Limits or Throttling.
  • Dependency Version Upgrades: The @storybook/builder-webpack5 dependency has been upgraded to version 6.2.0, and @storybook/preset-html-webpack has been upgraded to 7.0.0.
Changelog
  • code/frameworks/html-webpack5/package.json
    • Updated @storybook/builder-webpack5 from workspace:* to 6.2.0.
    • Updated @storybook/preset-html-webpack from workspace:* to 7.0.0.
Activity
  • This pull request was automatically created by Snyk to fix identified security vulnerabilities.
  • A warning was noted in the PR description indicating that yarn.lock failed to update and requires manual intervention.
  • The PR description provides links to Snyk's project report, PR template customization, and documentation on upgrade logic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, attempts to fix two security vulnerabilities by downgrading @storybook/builder-webpack5 and @storybook/preset-html-webpack. However, this approach is incorrect for this monorepo as it replaces workspace-local packages with outdated public versions, which will likely cause breakages. I've left a comment with a recommendation to use Yarn's resolutions to fix the underlying transitive dependency vulnerabilities without downgrading these core packages.

Comment on lines +50 to +53
"@storybook/builder-webpack5": "6.2.0",
"@storybook/global": "^5.0.0",
"@storybook/html": "workspace:*",
"@storybook/preset-html-webpack": "workspace:*",
"@storybook/preset-html-webpack": "7.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change from Snyk seems incorrect for this monorepo. It replaces workspace-local packages (workspace:*) with older, hardcoded versions from the public registry. This will likely break the project, as it's a major downgrade from the 8.3.0-beta.3 versions currently in the workspace.

Instead of downgrading these packages, the underlying vulnerabilities in ajv and qs should be addressed directly. A better approach would be to use Yarn's resolutions feature in the root package.json to force newer, non-vulnerable versions of these transitive dependencies across the entire workspace.

For example, you could add something like this to the root package.json:

"resolutions": {
  "ajv": "^6.12.6",
  "qs": "^6.11.2"
}

Please verify the correct non-vulnerable versions and apply this fix instead. This automated PR should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants