Skip to content

fix: pass file_size to ParquetObjectReader to avoid page-index panic #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shefeek-jinnah merged 1 commit into from
May 26, 2026
Merged

fix: pass file_size to ParquetObjectReader to avoid page-index panic #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/datafusion/src/reader/plantime/source.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,11 @@ impl CachedMetaReaderFactory {
) -> ParquetMetadataCacheReader {
let path = partitioned_file.object_meta.location.clone();
let store = Arc::clone(&self.store);
let mut inner = ParquetObjectReader::new(store, path.clone());
// Pass file_size to take the size-aware metadata path; parquet 58.1's
// suffix fallback mislabels `remainder_start` as 0 and panics when
// loading page indexes.
let mut inner = ParquetObjectReader::new(store, path.clone())
.with_file_size(partitioned_file.object_meta.size);

if let Some(hint) = metadata_size_hint {
inner = inner.with_footer_size_hint(hint);
Expand Down
Loading