fix: pass file_size to ParquetObjectReader to avoid page-index panic#5
Merged
Merged
Conversation
Without an explicit file_size, ParquetObjectReader falls back to the suffix-fetch metadata path, which mislabels `remainder_start` as 0 in parquet 58.1 and panics in `load_page_index_with_remainder` for any file containing page indexes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
ParquetObjectReader::get_metadata(parquet 58.1,arrow/async_reader/store.rs:238) picks one of two metadata-loading paths:file_sizeSome(_)ParquetMetaDataReader::load_and_finish(size-aware)NoneParquetMetaDataReader::load_via_suffix_and_finish(suffix fallback)Today we never call
with_file_size, so the suffix fallback is always chosen. That path has a bug in 58.1:load_metadata_via_suffix(file/metadata/reader.rs:706) returns the remainder asSome((0, suffix.slice(..metadata_start))). The0is the claimedremainder_start, but the bytes are from the file'stail (absolute offset
file_size - suffix_len), not offset0.load_metadata(reader.rs:653) correctly returnsSome((footer_start as usize, ...)).Then in
load_page_index_with_remainder(reader.rs:528):