Skip to content

fix: type params slot assignments #3946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pullfrog wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: type params slot assignments #3946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fresh-cooks-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hey-api/openapi-ts": patch
---

**plugin(@hey-api/client-core)**: fix params helper type errors with strict indexed slot assignments
8 changes: 5 additions & 3 deletions examples/openapi-ts-angular-common/src/client/core/params.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ interface Params {
query: Record<string, unknown>;
}

const stripEmptySlots = (params: Params) => {
type ParamsSlotMap = Record<Slot, unknown>;

const stripEmptySlots = (params: ParamsSlotMap) => {
for (const [slot, value] of Object.entries(params)) {
if (value && typeof value === 'object' && !Array.isArray(value) && !Object.keys(value).length) {
delete params[slot as Slot];
Expand All @@ -103,7 +105,7 @@ const stripEmptySlots = (params: Params) => {
};

export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsConfig) => {
const params: Params = {
const params: ParamsSlotMap = {
body: Object.create(null),
headers: Object.create(null),
path: Object.create(null),
Expand Down Expand Up @@ -165,5 +167,5 @@ export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsCo

stripEmptySlots(params);

return params;
return params as Params;
};
8 changes: 5 additions & 3 deletions examples/openapi-ts-angular/src/client/core/params.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ interface Params {
query: Record<string, unknown>;
}

const stripEmptySlots = (params: Params) => {
type ParamsSlotMap = Record<Slot, unknown>;

const stripEmptySlots = (params: ParamsSlotMap) => {
for (const [slot, value] of Object.entries(params)) {
if (value && typeof value === 'object' && !Array.isArray(value) && !Object.keys(value).length) {
delete params[slot as Slot];
Expand All @@ -103,7 +105,7 @@ const stripEmptySlots = (params: Params) => {
};

export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsConfig) => {
const params: Params = {
const params: ParamsSlotMap = {
body: Object.create(null),
headers: Object.create(null),
path: Object.create(null),
Expand Down Expand Up @@ -165,5 +167,5 @@ export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsCo

stripEmptySlots(params);

return params;
return params as Params;
};
8 changes: 5 additions & 3 deletions examples/openapi-ts-axios/src/client/core/params.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ interface Params {
query: Record<string, unknown>;
}

const stripEmptySlots = (params: Params) => {
type ParamsSlotMap = Record<Slot, unknown>;

const stripEmptySlots = (params: ParamsSlotMap) => {
for (const [slot, value] of Object.entries(params)) {
if (value && typeof value === 'object' && !Array.isArray(value) && !Object.keys(value).length) {
delete params[slot as Slot];
Expand All @@ -103,7 +105,7 @@ const stripEmptySlots = (params: Params) => {
};

export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsConfig) => {
const params: Params = {
const params: ParamsSlotMap = {
body: Object.create(null),
headers: Object.create(null),
path: Object.create(null),
Expand Down Expand Up @@ -165,5 +167,5 @@ export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsCo

stripEmptySlots(params);

return params;
return params as Params;
};
8 changes: 5 additions & 3 deletions examples/openapi-ts-fastify/src/client/core/params.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ interface Params {
query: Record<string, unknown>;
}

const stripEmptySlots = (params: Params) => {
type ParamsSlotMap = Record<Slot, unknown>;

const stripEmptySlots = (params: ParamsSlotMap) => {
for (const [slot, value] of Object.entries(params)) {
if (value && typeof value === 'object' && !Array.isArray(value) && !Object.keys(value).length) {
delete params[slot as Slot];
Expand All @@ -103,7 +105,7 @@ const stripEmptySlots = (params: Params) => {
};

export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsConfig) => {
const params: Params = {
const params: ParamsSlotMap = {
body: Object.create(null),
headers: Object.create(null),
path: Object.create(null),
Expand Down Expand Up @@ -165,5 +167,5 @@ export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsCo

stripEmptySlots(params);

return params;
return params as Params;
};
8 changes: 5 additions & 3 deletions examples/openapi-ts-fetch/src/client/core/params.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ interface Params {
query: Record<string, unknown>;
}

const stripEmptySlots = (params: Params) => {
type ParamsSlotMap = Record<Slot, unknown>;

const stripEmptySlots = (params: ParamsSlotMap) => {
for (const [slot, value] of Object.entries(params)) {
if (value && typeof value === 'object' && !Array.isArray(value) && !Object.keys(value).length) {
delete params[slot as Slot];
Expand All @@ -103,7 +105,7 @@ const stripEmptySlots = (params: Params) => {
};

export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsConfig) => {
const params: Params = {
const params: ParamsSlotMap = {
body: Object.create(null),
headers: Object.create(null),
path: Object.create(null),
Expand Down Expand Up @@ -165,5 +167,5 @@ export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsCo

stripEmptySlots(params);

return params;
return params as Params;
};
8 changes: 5 additions & 3 deletions examples/openapi-ts-ky/src/client/core/params.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ interface Params {
query: Record<string, unknown>;
}

const stripEmptySlots = (params: Params) => {
type ParamsSlotMap = Record<Slot, unknown>;

const stripEmptySlots = (params: ParamsSlotMap) => {
for (const [slot, value] of Object.entries(params)) {
if (value && typeof value === 'object' && !Array.isArray(value) && !Object.keys(value).length) {
delete params[slot as Slot];
Expand All @@ -103,7 +105,7 @@ const stripEmptySlots = (params: Params) => {
};

export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsConfig) => {
const params: Params = {
const params: ParamsSlotMap = {
body: Object.create(null),
headers: Object.create(null),
path: Object.create(null),
Expand Down Expand Up @@ -165,5 +167,5 @@ export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsCo

stripEmptySlots(params);

return params;
return params as Params;
};
8 changes: 5 additions & 3 deletions examples/openapi-ts-nestjs/src/client/core/params.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ interface Params {
query: Record<string, unknown>;
}

const stripEmptySlots = (params: Params) => {
type ParamsSlotMap = Record<Slot, unknown>;

const stripEmptySlots = (params: ParamsSlotMap) => {
for (const [slot, value] of Object.entries(params)) {
if (value && typeof value === 'object' && !Array.isArray(value) && !Object.keys(value).length) {
delete params[slot as Slot];
Expand All @@ -103,7 +105,7 @@ const stripEmptySlots = (params: Params) => {
};

export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsConfig) => {
const params: Params = {
const params: ParamsSlotMap = {
body: Object.create(null),
headers: Object.create(null),
path: Object.create(null),
Expand Down Expand Up @@ -165,5 +167,5 @@ export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsCo

stripEmptySlots(params);

return params;
return params as Params;
};
8 changes: 5 additions & 3 deletions examples/openapi-ts-next/src/client/core/params.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ interface Params {
query: Record<string, unknown>;
}

const stripEmptySlots = (params: Params) => {
type ParamsSlotMap = Record<Slot, unknown>;

const stripEmptySlots = (params: ParamsSlotMap) => {
for (const [slot, value] of Object.entries(params)) {
if (value && typeof value === 'object' && !Array.isArray(value) && !Object.keys(value).length) {
delete params[slot as Slot];
Expand All @@ -103,7 +105,7 @@ const stripEmptySlots = (params: Params) => {
};

export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsConfig) => {
const params: Params = {
const params: ParamsSlotMap = {
body: Object.create(null),
headers: Object.create(null),
path: Object.create(null),
Expand Down Expand Up @@ -165,5 +167,5 @@ export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsCo

stripEmptySlots(params);

return params;
return params as Params;
};
8 changes: 5 additions & 3 deletions examples/openapi-ts-ofetch/src/client/core/params.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ interface Params {
query: Record<string, unknown>;
}

const stripEmptySlots = (params: Params) => {
type ParamsSlotMap = Record<Slot, unknown>;

const stripEmptySlots = (params: ParamsSlotMap) => {
for (const [slot, value] of Object.entries(params)) {
if (value && typeof value === 'object' && !Array.isArray(value) && !Object.keys(value).length) {
delete params[slot as Slot];
Expand All @@ -103,7 +105,7 @@ const stripEmptySlots = (params: Params) => {
};

export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsConfig) => {
const params: Params = {
const params: ParamsSlotMap = {
body: Object.create(null),
headers: Object.create(null),
path: Object.create(null),
Expand Down Expand Up @@ -165,5 +167,5 @@ export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsCo

stripEmptySlots(params);

return params;
return params as Params;
};
8 changes: 5 additions & 3 deletions examples/openapi-ts-openai/src/client/core/params.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ interface Params {
query: Record<string, unknown>;
}

const stripEmptySlots = (params: Params) => {
type ParamsSlotMap = Record<Slot, unknown>;

const stripEmptySlots = (params: ParamsSlotMap) => {
for (const [slot, value] of Object.entries(params)) {
if (value && typeof value === 'object' && !Array.isArray(value) && !Object.keys(value).length) {
delete params[slot as Slot];
Expand All @@ -103,7 +105,7 @@ const stripEmptySlots = (params: Params) => {
};

export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsConfig) => {
const params: Params = {
const params: ParamsSlotMap = {
body: Object.create(null),
headers: Object.create(null),
path: Object.create(null),
Expand Down Expand Up @@ -165,5 +167,5 @@ export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsCo

stripEmptySlots(params);

return params;
return params as Params;
};
8 changes: 5 additions & 3 deletions examples/openapi-ts-pinia-colada/src/client/core/params.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ interface Params {
query: Record<string, unknown>;
}

const stripEmptySlots = (params: Params) => {
type ParamsSlotMap = Record<Slot, unknown>;

const stripEmptySlots = (params: ParamsSlotMap) => {
for (const [slot, value] of Object.entries(params)) {
if (value && typeof value === 'object' && !Array.isArray(value) && !Object.keys(value).length) {
delete params[slot as Slot];
Expand All @@ -103,7 +105,7 @@ const stripEmptySlots = (params: Params) => {
};

export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsConfig) => {
const params: Params = {
const params: ParamsSlotMap = {
body: Object.create(null),
headers: Object.create(null),
path: Object.create(null),
Expand Down Expand Up @@ -165,5 +167,5 @@ export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsCo

stripEmptySlots(params);

return params;
return params as Params;
};
8 changes: 5 additions & 3 deletions examples/openapi-ts-tanstack-angular-query-experimental/src/client/core/params.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ interface Params {
query: Record<string, unknown>;
}

const stripEmptySlots = (params: Params) => {
type ParamsSlotMap = Record<Slot, unknown>;

const stripEmptySlots = (params: ParamsSlotMap) => {
for (const [slot, value] of Object.entries(params)) {
if (value && typeof value === 'object' && !Array.isArray(value) && !Object.keys(value).length) {
delete params[slot as Slot];
Expand All @@ -103,7 +105,7 @@ const stripEmptySlots = (params: Params) => {
};

export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsConfig) => {
const params: Params = {
const params: ParamsSlotMap = {
body: Object.create(null),
headers: Object.create(null),
path: Object.create(null),
Expand Down Expand Up @@ -165,5 +167,5 @@ export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsCo

stripEmptySlots(params);

return params;
return params as Params;
};
8 changes: 5 additions & 3 deletions examples/openapi-ts-tanstack-react-query/src/client/core/params.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ interface Params {
query: Record<string, unknown>;
}

const stripEmptySlots = (params: Params) => {
type ParamsSlotMap = Record<Slot, unknown>;

const stripEmptySlots = (params: ParamsSlotMap) => {
for (const [slot, value] of Object.entries(params)) {
if (value && typeof value === 'object' && !Array.isArray(value) && !Object.keys(value).length) {
delete params[slot as Slot];
Expand All @@ -103,7 +105,7 @@ const stripEmptySlots = (params: Params) => {
};

export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsConfig) => {
const params: Params = {
const params: ParamsSlotMap = {
body: Object.create(null),
headers: Object.create(null),
path: Object.create(null),
Expand Down Expand Up @@ -165,5 +167,5 @@ export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsCo

stripEmptySlots(params);

return params;
return params as Params;
};
8 changes: 5 additions & 3 deletions examples/openapi-ts-tanstack-svelte-query/src/client/core/params.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ interface Params {
query: Record<string, unknown>;
}

const stripEmptySlots = (params: Params) => {
type ParamsSlotMap = Record<Slot, unknown>;

const stripEmptySlots = (params: ParamsSlotMap) => {
for (const [slot, value] of Object.entries(params)) {
if (value && typeof value === 'object' && !Array.isArray(value) && !Object.keys(value).length) {
delete params[slot as Slot];
Expand All @@ -103,7 +105,7 @@ const stripEmptySlots = (params: Params) => {
};

export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsConfig) => {
const params: Params = {
const params: ParamsSlotMap = {
body: Object.create(null),
headers: Object.create(null),
path: Object.create(null),
Expand Down Expand Up @@ -165,5 +167,5 @@ export const buildClientParams = (args: ReadonlyArray<unknown>, fields: FieldsCo

stripEmptySlots(params);

return params;
return params as Params;
};
Loading
Loading