fix: type params slot assignments#3946
Open
pullfrog[bot] wants to merge 1 commit into
Open
Conversation
|
|
🦋 Changeset detectedLatest commit: 9208584 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@hey-api/codegen-core
@hey-api/json-schema-ref-parser
@hey-api/nuxt
@hey-api/openapi-ts
@hey-api/shared
@hey-api/spec-types
@hey-api/types
@hey-api/vite-plugin
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3946 +/- ##
=======================================
Coverage 37.40% 37.40%
=======================================
Files 654 654
Lines 22456 22456
Branches 6538 6531 -7
=======================================
Hits 8400 8400
Misses 11397 11397
Partials 2659 2659
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3862
Testing
pnpm turbo run typecheck --filter=@hey-api/openapi-tspnpm exec vitest run --project @hey-api/openapi-ts src/plugins/@hey-api/client-core/__tests__/params.test.tspnpm exec vitest run --update --project @test/openapi-ts --project @test/openapi-ts-sdks --project @test/openapi-ts-tanstack-query-v5 --project @test/openapi-ts-valibot-v1 --project @test/openapi-ts-zod-v3 --project @test/openapi-ts-zod-v4pnpm examples:generatepnpm turbo run typecheck --filter=@test/openapi-tspnpm exec tsc --ignoreConfig --strict --stableTypeOrdering --target ES2022 --module ESNext --moduleResolution Bundler --lib ES2022,DOM,DOM.Iterable --noEmit packages/openapi-ts-tests/main/test/__snapshots__/3.1.x/clients/@hey-api/client-fetch/default/core/params.gen.tspnpm lintGPT| 𝕏