Skip to content

fix(github): apply guest token to images in markdown sync #10659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArtyomSavchenko merged 2 commits into from
Mar 25, 2026
Merged

fix(github): apply guest token to images in markdown sync #10659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc32c3d
fix(github): apply guest token to images in markdown sync (#10516)
dnplkndll Mar 21, 2026
90549d7
fix: formatting (prettier/eslint)
dnplkndll Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions services/github/pod-github/src/sync/issues.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
GithubIntegrationRepository,
GithubIssueStateReason,
GithubProject,
IntegrationRepositoryData,

Check failure on line 32 in services/github/pod-github/src/sync/issues.ts

View workflow job for this annotation

GitHub Actions / formatting 

'IntegrationRepositoryData' is defined but never used
GithubIssue as TGithubIssue
} from '@hcengineering/github'
import task, { TaskType, calcRank } from '@hcengineering/task'
Expand Down Expand Up @@ -523,9 +523,7 @@
info.repository as Ref<GithubIntegrationRepository>,
container.project,
taskTypes[0]._id,
repo as GithubIntegrationRepository & {
repository: IntegrationRepositoryData
},
repo,
!markdownCompatible
)
},
Expand Down
6 changes: 5 additions & 1 deletion services/github/pod-github/src/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ import { ReviewCommentSyncManager } from './sync/reviewComments'
import { ReviewThreadSyncManager } from './sync/reviewThreads'
import { ReviewSyncManager } from './sync/reviews'
import { UsersSyncManager, fetchViewerDetails } from './sync/users'
import { appendGuestLinkToImage } from './sync/guest'
import { errorToObj } from './sync/utils'
import {
ContainerFocus,
Expand Down Expand Up @@ -243,7 +244,10 @@ export class GithubWorker implements IntegrationManager {
concatLink(this.getBranding()?.front ?? config.FrontURL, `/browse/?workspace=${this.workspace.uuid}`),
// TODO storage URL
concatLink(this.getBranding()?.front ?? config.FrontURL, `/files/${this.workspace.uuid}/`),
preprocessor
preprocessor ??
(async (nodes) => {
appendGuestLinkToImage(nodes, this.workspace.uuid)
})
)
}

Expand Down
Loading