fix(github): apply guest token to images in markdown sync#10659
Open
dnplkndll wants to merge 1 commit intohcengineering:developfrom
Open
fix(github): apply guest token to images in markdown sync#10659dnplkndll wants to merge 1 commit intohcengineering:developfrom
dnplkndll wants to merge 1 commit intohcengineering:developfrom
Conversation
…ing#10516) The appendGuestLinkToImage function existed but was never called from getMarkdown(). Add it as the default preprocessor so image URLs include a guest JWT token, allowing them to render on GitHub. Signed-off-by: Daniel Kendall <dkendall@ledoweb.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Don Kendall <kendall@donkendall.com>
|
Connected to Huly®: UBERF-15990 |
Contributor
Author
Verified on self-hosted instanceTested on Test: Issue created in Huly with inline image → synced to GitHubSynced issue: With fix (this PR): Image URL includes Without fix (no token): Same URL without The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10516
appendGuestLinkToImage()inservices/github/pod-github/src/sync/guest.tsstamps a guest JWT token onto image URLs before serialization to GitHub markdowngetMarkdown()preprocessor ?? (async (nodes) => { appendGuestLinkToImage(nodes, this.workspace.uuid) }), so all 10+ call sites automatically get image token injection when no custom preprocessor is providedfoundations/core/packages/text-markdown/src/serializer.ts:175-191already handlesattrs.token→&token=in URLsTest plan
&token=<guest-jwt>)🤖 Generated with Claude Code