Skip to content

FE-703: Add /planning-pr skill#99

Open
kostandinang wants to merge 1 commit into
mainfrom
ka/fe-703-planning-pr-skill
Open

FE-703: Add /planning-pr skill#99
kostandinang wants to merge 1 commit into
mainfrom
ka/fe-703-planning-pr-skill

Conversation

@kostandinang
Copy link
Copy Markdown
Contributor

@kostandinang kostandinang commented May 7, 2026

What

Adds a /planning-pr agent skill that captures when planning-doc edits warrant a dedicated PR off main vs an inline commit on a feature branch.

Linear: FE-703 (child of FE-699).

Why

Every paragraph-level rewrite of memory/PLAN.md / memory/SPEC.md competes with feature branches for the same lines on rebase. This skill encodes the project's process-only mitigation: serialize all paragraph-level rewrites and any SPEC.md tracked-ID additions through dedicated planning PRs.

Doesn't preclude the structural fixes drafted under FE-699 (union merge driver, per-frontier-item file decomposition) — this just makes the convention discoverable.

Change

One new file: .agents/skills/planning-pr/SKILL.md (73 lines, no code, no tests).

Test plan

  • CI green
  • Next /ln-sync invocation routes through this skill before committing

Encodes the project convention that paragraph-level rewrites of
memory/PLAN.md and any change to memory/SPEC.md tracked-ID rows
(Assumptions / Decisions / Requirements / Invariants) go on a separate
planning PR off main, scoped to memory/* files only, while small
in-place edits stay on the feature branch.

Triggers on: about-to-edit memory/* beyond a one-line tick, where-to-commit
questions, post-/ln-sync substantive edits, SPEC.md tracked-ID row changes.

Body covers: decision rule, workflow (Linear -> branch off main -> memory/*
only -> PR -> land first -> downstream restack), anti-patterns, common
entry points, worked example, cross-refs to /cli-linear, /cli-graphite,
/ln-sync.

Process-only mitigation under FE-699; structural proposals from
docs/praxis/proposals/merge-friction-proposals.md remain open separately.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented May 7, 2026

PR Summary

Low Risk
Adds a new process/documentation skill only; no runtime code paths or data/security-sensitive logic are affected.

Overview
Adds a new agent skill doc, planning-pr, that formalizes when edits to memory/PLAN.md/memory/SPEC.md must be split into a separate planning-only PR off main (especially any changes to sequential tracked-ID rows).

Defines the decision threshold, required workflow (Linear → Graphite branch off mainmemory/*-only diff → merge before restacking), and lists anti-patterns/entry points to reduce merge conflicts across parallel feature branches.

Reviewed by Cursor Bugbot for commit 305d868. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor Author

kostandinang commented May 7, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kostandinang kostandinang requested a review from lunelson May 7, 2026 14:40
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 7, 2026

🤖 Augment PR Summary

Summary: This PR adds a new planning-pr skill that codifies when planning-document edits should be split into a dedicated “planning PR” off main.

Changes:

  • Introduced .agents/skills/planning-pr/SKILL.md describing the decision threshold (one-line tweaks vs paragraph rewrites) and a hard rule for SPEC tracked-ID changes.
  • Documented an end-to-end workflow (Linear issue → branch off mainmemory/*-only edits → verify → PR → merge → restack downstream).
  • Added anti-patterns and common entry points (e.g., after /ln-sync or when conflicts arise in memory/PLAN.md/memory/SPEC.md).

Technical Notes: The skill’s core intent is to serialize high-conflict planning edits by landing them on main first, so feature stacks can rebase onto a shared planning baseline.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@kostandinang kostandinang self-assigned this May 7, 2026
@kostandinang kostandinang changed the title FE-703: Add /planning-pr skill encoding planning-PR convention FE-703: Add /planning-pr skill May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant