Skip to content

fix(ratewise): 收斂 Nitro 設計 token 覆蓋#398

Open
s123104 wants to merge 1 commit into
chore/ratewise-production-governancefrom
codex/ratewise-token-ssot-nitro
Open

fix(ratewise): 收斂 Nitro 設計 token 覆蓋#398
s123104 wants to merge 1 commit into
chore/ratewise-production-governancefrom
codex/ratewise-token-ssot-nitro

Conversation

@s123104
Copy link
Copy Markdown
Contributor

@s123104 s123104 commented May 16, 2026

摘要

  • 補齊 Nitro legacy primary token、語義色彩 alias 與 focus ring offset,避免設定頁深色主題露出淺底或白色 ring。
  • html / body / critical bootstrap / applyTheme 收斂到 STYLE_DEFINITIONS 與 design token SSOT。
  • 新增 table-driven drift guard,防止 bootstrap map、critical skeleton vars、runtime theme map 再次漂移。
  • 新增 patch changeset 與 002 獎懲紀錄。

驗證

  • pnpm --filter @app/ratewise test -- src/config/design-tokens.test.ts src/config/__tests__/theme-consistency.test.ts
  • pnpm --filter @app/ratewise typecheck
  • pnpm exec prettier --check apps/ratewise/index.html apps/ratewise/tailwind.config.ts apps/ratewise/src/index.css apps/ratewise/src/config/design-tokens.ts apps/ratewise/src/config/design-tokens.test.ts apps/ratewise/src/config/themes.ts .changeset/ratewise-nitro-token-ssot.md docs/dev/002_development_reward_penalty_log.md
  • pnpm --filter @app/ratewise build
  • Production preview smoke:Chromium desktop / WebKit iPhone 15,確認 Nitro html/body background、color-scheme: dark、surface、primary active/ring 與 ring offset。
  • Commit hook:pre-commit 5 步驟通過。
  • Push hook:typecheck、pnpm testpnpm build:ratewise 通過。

已知殘留

  • Production preview 仍會出現既有 React #418 hydration console error;本 PR 的 token / critical CSS smoke 已通過,該項留給後續 SSG/PWA hydration PR 處理。

- 補齊 Nitro legacy token、語義色彩 alias 與 focus ring offset,避免設定頁深色主題露出淺底
- 將 html/body 與 critical bootstrap 收斂到語義背景,並讓 applyTheme 同步 critical color-scheme
- 新增 changeset、002 獎懲記錄與 token/critical path 漂移防線

測試:focused Vitest、typecheck、Prettier check、build、Chromium/WebKit smoke。
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 3 package(s) with unknown licenses.
See the Details below.

License Issues

.github/workflows/ratewise-production-governance.yml

PackageVersionLicenseIssue Type
actions/checkout6.*.*NullUnknown License
actions/setup-node6.*.*NullUnknown License
pnpm/action-setup6.*.*NullUnknown License
Denied Licenses: GPL-3.0, AGPL-3.0

OpenSSF Scorecard

PackageVersionScoreDetails
actions/actions/checkout 6.*.* 🟢 5.7
Details
CheckScoreReason
Maintained⚠️ 01 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
Code-Review🟢 10all changesets reviewed
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
Packaging⚠️ -1packaging workflow not detected
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 9security policy file detected
Branch-Protection🟢 5branch protection is not maximal on development and all release branches
SAST🟢 8SAST tool detected but not run on all commits
actions/actions/setup-node 6.*.* 🟢 5.8
Details
CheckScoreReason
Maintained🟢 79 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 7
Code-Review🟢 10all changesets reviewed
Packaging⚠️ -1packaging workflow not detected
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 9binaries present in source code
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 9security policy file detected
Branch-Protection⚠️ 1branch protection is not maximal on development and all release branches
SAST🟢 9SAST tool is not run on all commits -- score normalized to 9
actions/pnpm/action-setup 6.*.* 🟢 5.3
Details
CheckScoreReason
Code-Review🟢 3Found 10/30 approved changesets -- score normalized to 3
Maintained🟢 1030 commit(s) and 7 issue activity found in the last 90 days -- score normalized to 10
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1packaging workflow not detected
Pinned-Dependencies🟢 10all dependencies are pinned
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Fuzzing⚠️ 0project is not fuzzed
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
Security-Policy⚠️ 0security policy file not detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Files

  • .github/workflows/ratewise-production-governance.yml

@github-actions
Copy link
Copy Markdown
Contributor

✅ SEO 審計通過!所有 2026 標準驗證項目都符合要求。

  • ✅ Sitemap 2026 標準
  • ✅ Breadcrumb Schema
  • ✅ JSON-LD 結構化數據
  • ✅ 內部連結結構

@github-actions
Copy link
Copy Markdown
Contributor

Lighthouse Production Baseline ✅

  • 狀態:pass
  • 目標網址:https://app.haotool.org/ratewise/
  • 實際執行:3 次
  • 退化容忍:5%
  • Baseline 更新時間:2026-05-16T17:30:11.981Z

檢查細節

  • 無異常,指標符合要求

@s123104 s123104 changed the base branch from main to chore/ratewise-production-governance May 16, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant