Skip to content

fix(ratewise): 收斂支援資訊導覽體驗#404

Open
s123104 wants to merge 2 commits into
codex/ratewise-token-ssot-nitrofrom
codex/ratewise-support-info-ia
Open

fix(ratewise): 收斂支援資訊導覽體驗#404
s123104 wants to merge 2 commits into
codex/ratewise-token-ssot-nitrofrom
codex/ratewise-support-info-ia

Conversation

@s123104
Copy link
Copy Markdown
Contributor

@s123104 s123104 commented May 16, 2026

摘要

  • Stacked on fix(ratewise): 收斂 Nitro 設計 token 覆蓋 #398,重構支援與資訊入口、公開內容頁 header 與支援分群導覽
  • 設定頁支援區改為四語系描述卡片,並補齊 skeleton、i18n 與 basename-aware 測試
  • 新增 active pill semantic token,避免 Nitro/深色主題 active link 文字漂移

驗證

  • pnpm --filter @app/ratewise test -- src/pages/OpenData.test.tsx src/components/tests/PageNavHeader.test.tsx
  • pnpm --filter @app/ratewise typecheck
  • pre-commit 5 steps passed
  • pre-push passed: pnpm typecheck, pnpm test, pnpm build:ratewise
  • Playwright smoke: Chromium, Firefox, WebKit/iPhone 15 for FAQ, SEO Tech, Settings, Guide anchors, manifest and SW

- 重構支援與資訊入口為 SSOT 導覽與四語系描述卡片

- 補齊公開頁 safe-area header、行動版 footer 與高對比 active pill token

- 同步 SEO 技術頁、Settings skeleton、Guide 錨點與測試 guardrail

測試:pnpm --filter @app/ratewise test -- PageNavHeader Guide Skeleton tokens Settings

測試:pnpm --filter @app/ratewise typecheck

測試:pnpm --filter @app/ratewise build

測試:Playwright Chromium Firefox WebKit iPhone smoke
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions
Copy link
Copy Markdown
Contributor

✅ SEO 審計通過!所有 2026 標準驗證項目都符合要求。

  • ✅ Sitemap 2026 標準
  • ✅ Breadcrumb Schema
  • ✅ JSON-LD 結構化數據
  • ✅ 內部連結結構

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73d7d3689d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/ratewise/src/components/PageNavHeader.tsx Outdated
- 正規化 PageNavHeader 當前 pathname,讓無 trailing slash 的支援頁仍顯示導覽。

- 補一般與 basename 部署下無 trailing slash 的 active pill 回歸測試。

- 更新 changeset 與 002 稽核記錄,對應 PR404 Codex review thread。

測試:PageNavHeader focused vitest 6 tests、RateWise typecheck。
@github-actions
Copy link
Copy Markdown
Contributor

✅ SEO 審計通過!所有 2026 標準驗證項目都符合要求。

  • ✅ Sitemap 2026 標準
  • ✅ Breadcrumb Schema
  • ✅ JSON-LD 結構化數據
  • ✅ 內部連結結構

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant