Skip to content

feat: Refactors 3d-simple-map to use declarative model. #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
willum070 wants to merge 15 commits into from
Closed

feat: Refactors 3d-simple-map to use declarative model. #1138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8ee2790
feat: Refactors 3d-simple-map to use declarative model.
willum070 Feb 25, 2026
f80c7e3
Add a check for inner map
willum070 Feb 26, 2026
fe8c813
Add listener for map loading before accessing inner map
willum070 Feb 26, 2026
72b1d94
Merge branch 'main' into refactor-3d-simple-map
willum070 Feb 26, 2026
8994271
Change event listener to use customElements API
willum070 Mar 5, 2026
5754e27
Merge branch 'main' into refactor-3d-simple-map
willum070 Mar 5, 2026
e78dd4e
Refactor initMap to use native addEventListener.
willum070 Mar 5, 2026
c49d4b5
Test with no event listener.
willum070 Mar 5, 2026
96c74cf
Set map options using addEventListener
willum070 Mar 5, 2026
487dad4
Refactor map options setting for 3D map
willum070 Mar 5, 2026
ce5a59a
Merge branch 'main' into refactor-3d-simple-map
willum070 Mar 5, 2026
3606d63
Remove code for map type option.
willum070 Mar 5, 2026
a3b8754
Apply suggestion from @chrisjshull
willum070 Mar 5, 2026
0a81be5
Apply suggestion from @chrisjshull
willum070 Mar 5, 2026
255b227
Remove extra newline in initMap function
willum070 Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions samples/3d-simple-map/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!doctype html>
<!--
@license
Copyright 2025 Google LLC. All Rights Reserved.
Copyright 2026 Google LLC. All Rights Reserved.
SPDX-License-Identifier: Apache-2.0
-->
<!-- [START maps_3d_simple_map] -->
Expand All @@ -11,11 +11,18 @@

<link rel="stylesheet" type="text/css" href="./style.css" />
<script type="module" src="./index.js"></script>
</head>
<body>
<!-- prettier-ignore -->
<script>(g=>{var h,a,k,p="The Google Maps JavaScript API",c="google",l="importLibrary",q="__ib__",m=document,b=window;b=b[c]||(b[c]={});var d=b.maps||(b.maps={}),r=new Set,e=new URLSearchParams,u=()=>h||(h=new Promise(async(f,n)=>{await (a=m.createElement("script"));e.set("libraries",[...r]+"");for(k in g)e.set(k.replace(/[A-Z]/g,t=>"_"+t[0].toLowerCase()),g[k]);e.set("callback",c+".maps."+q);a.src=`https://maps.${c}apis.com/maps/api/js?`+e;d[q]=f;a.onerror=()=>h=n(Error(p+" could not load."));a.nonce=m.querySelector("script[nonce]")?.nonce||"";m.head.append(a)}));d[l]?console.warn(p+" only loads once. Ignoring:",g):d[l]=(f,...n)=>r.add(f)&&u().then(()=>d[l](f,...n))})
({key: "AIzaSyA6myHzS10YXdcazAFalmXvDkrYCp5cLc8", v: "weekly",});</script>
</head>
<body>
<gmp-map-3d
center="37.7704, -122.3985, 500"
zoom="15"
tilt="67.5"
mode="hybrid"
gesture-handling="cooperative">
</gmp-map-3d>
</body>
</html>
<!-- [END maps_3d_simple_map] -->
15 changes: 2 additions & 13 deletions samples/3d-simple-map/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,11 @@
/*
* @license
* Copyright 2025 Google LLC. All Rights Reserved.
* Copyright 2026 Google LLC. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/

//@ts-nocheck
// [START maps_3d_simple_map]
async function initMap() {
const { Map3DElement } = await google.maps.importLibrary('maps3d');

const map = new Map3DElement({
center: { lat: 37.7704, lng: -122.3985, altitude: 500 },
tilt: 67.5,
mode: 'HYBRID',
gestureHandling: 'COOPERATIVE',
});

document.body.append(map);
google.maps.importLibrary('maps3d');
}

initMap();
Expand Down
6 changes: 2 additions & 4 deletions samples/3d-simple-map/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
/*
* @license
* Copyright 2025 Google LLC. All Rights Reserved.
* Copyright 2026 Google LLC. All Rights Reserved.
* SPDX-License-Identifier: Apache-2.0
*/
/* [START maps_3d_simple_map] */
/* * Always set the map height explicitly to define the size of the div element
* that contains the map.
*/
#gmp-map-3d {
height: 100%;
}

html,
body {
height: 100%;
Expand Down
Loading