feat: Refactors 3d-simple-map to use declarative model.#1138
Closed
feat: Refactors 3d-simple-map to use declarative model.#1138
Conversation
This change should tell us more about why the test is failing (I suspect it's a race condition)
Taking another tack: Wait for the map to finish loading before accessing the inner map. Hopefully this moves the needle correctly.
willum070
commented
Feb 26, 2026
This is a better pattern than addEventListenerOnce.
Removed event listener for 'gmp-ready' and set map options directly. Also removed innerMap since it is not needed.
Add JS event listener for 'gmp-ready' to set map options.
Removed event listener for 'gmp-ready' and directly set map options.
Removed map options setting for mapTypeControl. Now this "simple" sample is the most simple it can be.
chrisjshull
reviewed
Mar 5, 2026
Co-authored-by: Chris J. Shull <chrisjshull@gmail.com>
Co-authored-by: Chris J. Shull <chrisjshull@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following things: