Skip to content

tests(streaming): use UTC timezone for start_timestamp and improve flaky retry delay #18110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shuoweil wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

tests(streaming): use UTC timezone for start_timestamp and improve flaky retry delay #18110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/bigframes/tests/system/large/streaming/test_bigtable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

import time
import uuid
from datetime import datetime, timedelta
from datetime import datetime, timedelta, timezone
from typing import Generator

import pytest
Expand Down Expand Up @@ -68,7 +68,7 @@ def bigtable_table(
bt_table.delete()


@pytest.mark.flaky(retries=3, delay=10)
@pytest.mark.flaky(retries=3, delay=30)
def test_streaming_df_to_bigtable(
session_load: bigframes.Session, bigtable_table: table.Table
):
Expand All @@ -92,7 +92,7 @@ def test_streaming_df_to_bigtable(
bigtable_options={},
job_id=None,
job_id_prefix=job_id_prefix,
start_timestamp=datetime.now() - timedelta(days=1),
start_timestamp=datetime.now(timezone.utc) - timedelta(days=1),
)

# wait 200 seconds in order to ensure the query doesn't stop
Expand Down
6 changes: 3 additions & 3 deletions packages/bigframes/tests/system/large/streaming/test_pubsub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

import uuid
from concurrent import futures
from datetime import datetime, timedelta
from datetime import datetime, timedelta, timezone
from typing import Generator

import pytest
Expand Down Expand Up @@ -59,7 +59,7 @@ def pubsub_topic_subscription_ids(
subscriber.delete_subscription(subscription=subscription_name)


@pytest.mark.flaky(retries=3, delay=10)
@pytest.mark.flaky(retries=3, delay=30)
def test_streaming_df_to_pubsub(
session_load: bigframes.Session, pubsub_topic_subscription_ids: tuple[str, str]
):
Expand Down Expand Up @@ -100,7 +100,7 @@ def callback(message):
service_account_email="streaming-testing@bigframes-load-testing.iam.gserviceaccount.com",
job_id=None,
job_id_prefix=job_id_prefix,
start_timestamp=datetime.now() - timedelta(days=1),
start_timestamp=datetime.now(timezone.utc) - timedelta(days=1),
)
try:
# wait 200 seconds in order to ensure the query doesn't stop
Expand Down
Loading