tests(streaming): use UTC timezone for start_timestamp and improve flaky retry delay - #18110
Open
shuoweil wants to merge 1 commit into
Open
tests(streaming): use UTC timezone for start_timestamp and improve flaky retry delay#18110shuoweil wants to merge 1 commit into
shuoweil wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the streaming tests for BigTable and PubSub by switching from naive local datetimes to timezone-aware UTC datetimes using datetime.now(timezone.utc). Additionally, it increases the retry delay for flaky tests from 10 seconds to 30 seconds to improve test stability. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
tests/system/large/streaming/test_bigtable.pyandtests/system/large/streaming/test_pubsub.py, continuous streaming queries are launched from BigQuery to Bigtable and Pub/Sub sinks.start_timestampwas initialized with naive localdatetime.now() - timedelta(days=1), which could cause timestamp offset mismatches across different CI runner timezones.Changes
start_timestampto explicit UTC timezone (datetime.now(timezone.utc) - timedelta(days=1)).@pytest.mark.flakyretry delay from 10s to 30s.Fixes #<545715930> 🦕