Skip to content

feat: remove unit tests from the generator #8130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
feywind wants to merge 20 commits into
base: main
Choose a base branch
from
Open

feat: remove unit tests from the generator #8130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
0cec36d
feat: remove unit tests from the generator
feywind Apr 28, 2026
fc5a82d
chore: update gax version, remove test scripts
feywind Apr 28, 2026
9e0a757
fix: also remove test paths from tsconfig
feywind Apr 28, 2026
b96fe34
build: package.json issues
feywind Apr 29, 2026
cfbde40
chore: merge remote-tracking branch 'remotes/origin/main' into feywin…
feywind Apr 30, 2026
f340b1e
chore: merge remote-tracking branch 'remotes/origin/main' into feywin…
feywind Apr 30, 2026
a8017c6
build: yarn changes
feywind Apr 30, 2026
d921b4c
chore: update baselines
feywind Apr 30, 2026
2c29ddd
fix: ESM import() changes from 18 to 24 caused error
feywind Apr 30, 2026
2c49fd0
fix: suggestion from other PR for efficiency
feywind Apr 30, 2026
ce187db
chore: merge remote-tracking branch 'remotes/origin/main' into feywin…
feywind May 1, 2026
12a801a
chore: remove unused test fixtures
feywind May 1, 2026
eb9ffe7
chore: update baselines affected by merge
feywind May 1, 2026
9a2bebc
build: one more gax version update
feywind May 1, 2026
fa99fe7
chore: merge remote-tracking branch 'remotes/origin/main' into feywin…
feywind May 1, 2026
0d51768
build: potential fix for bazel CI issues on generator
feywind May 5, 2026
c5d7858
build: re-add mocha for main generator test, update baselines and loc…
feywind May 5, 2026
fc20fff
chore: revert "chore: remove unused test fixtures"
feywind May 6, 2026
5e87553
chore: merge branch 'feywind-gh8018-remove-gen' of https://github.com…
feywind May 6, 2026
3a29ae5
chore: merge remote-tracking branch 'remotes/origin/main' into feywin…
feywind May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions core/generator/gapic-generator-typescript/WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,18 @@ rules_js_register_toolchains(node_version = DEFAULT_NODE_VERSION)

load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock", "pnpm_repository")

pnpm_repository(name = "pnpm")

load("//:pnpm_install.bzl", "pnpm_install")
pnpm_install(name = "pnpm_install_lockfile")

load("@pnpm_install_lockfile//:pnpm_install.bzl", "PNPM_INSTALL_STATUS")

npm_translate_lock(
name = "npm",
pnpm_lock = "//:pnpm-lock.yaml",
update_pnpm_lock = True,
data = ["//:package.json"],
)
pnpm_repository(name = "pnpm")
load("@npm//:repositories.bzl", "npm_repositories")
npm_repositories()

# To regenerate the lock file, run:
# bazelisk run -- @pnpm//:pnpm --dir $PWD install --lockfile-only
# More information: https://github.com/aspect-build/rules_js/blob/main/docs/faq.md#can-i-use-bazel-managed-pnpm

1,162 changes: 0 additions & 1,162 deletions ...apic-generator-typescript/baselines/asset-esm/esm/test/gapic_asset_service_v1.ts.baseline
View file
Open in desktop

This file was deleted.

9 changes: 3 additions & 6 deletions core/generator/gapic-generator-typescript/baselines/asset-esm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,17 +63,14 @@
"system-test:cjs": "c8 mocha build/cjs/system-test",
"system-test:esm": "c8 mocha build/esm/system-test",
"system-test": "npm run system-test:esm && npm run system-test:cjs",
"test:cjs": "c8 mocha build/cjs/test",
"test:esm": "c8 mocha build/esm/test",
"test": "npm run test:cjs && npm run test:esm",
"test": "echo no unit tests for generated libraries 🙈",
"compile:esm": "tsc -p ./tsconfig.esm.json && cp -r esm/src/json-helper.cjs build/esm/src/json-helper.cjs",
"babel": "babel esm --out-dir build/cjs --ignore \"esm/**/*.d.ts\" --extensions \".ts\" --out-file-extension .cjs --copy-files",
"compile:cjs": "tsc -p ./tsconfig.json && npm run babel",
"compile": "npm run compile:esm && rm -rf esm/src/json-helper.d.cts && npm run compile:cjs && rm -rf build/protos && cp -r protos build/protos",
"samples-test": "cd samples/ && npm link ../ && npm i && npm test"
"compile": "npm run compile:esm && rm -rf esm/src/json-helper.d.cts && npm run compile:cjs && rm -rf build/protos && cp -r protos build/protos"
},
"dependencies": {
"google-gax": "^5.1.1-rc.1"
"google-gax": "^5.0.6"
},
"devDependencies": {
"@babel/cli": "^7.28.3",
Expand Down
2 changes: 0 additions & 2 deletions core/generator/gapic-generator-typescript/baselines/asset-esm/tsconfig.json.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
"include": [
"esm/src/*.ts",
"esm/src/**/*.ts",
"esm/test/*.ts",
"esm/test/**/*.ts",
"esm/src/**/*.json",
"esm/system-test/*.ts",
"esm/src/*.cjs",
Expand Down
4 changes: 2 additions & 2 deletions core/generator/gapic-generator-typescript/baselines/asset/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
"lint": "gts check",
"prepare": "npm run compile-protos && npm run compile",
"system-test": "c8 mocha build/system-test",
"test": "c8 mocha build/test"
"test": "echo no unit tests for generated libraries 🙈"
},
"dependencies": {
"google-gax": "^5.1.1-rc.1"
"google-gax": "^5.0.6"
},
"devDependencies": {
"@types/mocha": "^10.0.10",
Expand Down
1,153 changes: 0 additions & 1,153 deletions ...erator/gapic-generator-typescript/baselines/asset/test/gapic_asset_service_v1.ts.baseline
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions core/generator/gapic-generator-typescript/baselines/asset/tsconfig.json.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
"include": [
"src/*.ts",
"src/**/*.ts",
"test/*.ts",
"test/**/*.ts",
"system-test/*.ts",
"src/**/*.json",
"samples/**/*.json",
Expand Down
943 changes: 0 additions & 943 deletions ...cript/baselines/bigquery-storage-esm/esm/test/gapic_big_query_storage_v1beta1.ts.baseline
View file
Open in desktop

This file was deleted.

9 changes: 3 additions & 6 deletions core/generator/gapic-generator-typescript/baselines/bigquery-storage-esm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,17 +63,14 @@
"system-test:cjs": "c8 mocha build/cjs/system-test",
"system-test:esm": "c8 mocha build/esm/system-test",
"system-test": "npm run system-test:esm && npm run system-test:cjs",
"test:cjs": "c8 mocha build/cjs/test",
"test:esm": "c8 mocha build/esm/test",
"test": "npm run test:cjs && npm run test:esm",
"test": "echo no unit tests for generated libraries 🙈",
"compile:esm": "tsc -p ./tsconfig.esm.json && cp -r esm/src/json-helper.cjs build/esm/src/json-helper.cjs",
"babel": "babel esm --out-dir build/cjs --ignore \"esm/**/*.d.ts\" --extensions \".ts\" --out-file-extension .cjs --copy-files",
"compile:cjs": "tsc -p ./tsconfig.json && npm run babel",
"compile": "npm run compile:esm && rm -rf esm/src/json-helper.d.cts && npm run compile:cjs && rm -rf build/protos && cp -r protos build/protos",
"samples-test": "cd samples/ && npm link ../ && npm i && npm test"
"compile": "npm run compile:esm && rm -rf esm/src/json-helper.d.cts && npm run compile:cjs && rm -rf build/protos && cp -r protos build/protos"
},
"dependencies": {
"google-gax": "^5.1.1-rc.1"
"google-gax": "^5.0.6"
},
"devDependencies": {
"@babel/cli": "^7.28.3",
Expand Down
2 changes: 0 additions & 2 deletions ...enerator/gapic-generator-typescript/baselines/bigquery-storage-esm/tsconfig.json.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
"include": [
"esm/src/*.ts",
"esm/src/**/*.ts",
"esm/test/*.ts",
"esm/test/**/*.ts",
"esm/src/**/*.json",
"esm/system-test/*.ts",
"esm/src/*.cjs",
Expand Down
4 changes: 2 additions & 2 deletions core/generator/gapic-generator-typescript/baselines/bigquery-storage/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
"lint": "gts check",
"prepare": "npm run compile-protos && npm run compile",
"system-test": "c8 mocha build/system-test",
"test": "c8 mocha build/test"
"test": "echo no unit tests for generated libraries 🙈"
},
"dependencies": {
"google-gax": "^5.1.1-rc.1"
"google-gax": "^5.0.6"
},
"devDependencies": {
"@types/mocha": "^10.0.10",
Expand Down
Loading
Loading