Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the Nunjucks templates used for generating unit tests in both CommonJS and ESM formats for TypeScript GAPIC clients. The reviewer pointed out that the generator's orchestration logic must be updated to remove references to these deleted templates to prevent runtime crashes. Additionally, it is recommended to clean up other templates, such as package.json.njk and README.md.njk, to remove now-obsolete test dependencies and documentation for the sake of consistency.
…d-gh8018-remove-gen
…d-gh8018-remove-gen
There was a problem hiding this comment.
Why are we downgrading our gax version?
There was a problem hiding this comment.
It's actually not - there was a kerfuffle on npm versions. The newest release is 5.0.6, but we were making libraries with 5.1.1-rc1, which is way older. The older version was pulling in dependencies with vulns.
There was a problem hiding this comment.
We can remove sinon now right?
Do we need mocha or pack-n-play either?
There was a problem hiding this comment.
Sinon and pack-n-play are both used by the remaining system-test, but I think @danieljbruce is going to be removing those.
There was a problem hiding this comment.
I'll be removing pack and play, but gemini-cli didn't elect to remove sinon. I think sinon is used more in the unit tests. That is what I have noticed for nodejs-bigtable anyway.
There was a problem hiding this comment.
Yeah, pack-n-play is basically just used in the "make a package" test, and is probably not necessary anymore. Sinon is also used there, as well as mocha, so there's a bit of a chicken and egg problem. Whoever merges first should probably leave sinon/mocha and whoever merges second should remove both. I see some conflicts below, so maybe you already merged yours? I'll have to look.
There was a problem hiding this comment.
I haven't merged yet. I may even vote to make removing sinon a separate buganizer item just so the change for the main issue in question can get through code review.
|
To review this PR and make sure my system tests are aligned I looked at the Overall it LGTM, but the only thing I wonder about at this point is if the
|
…d-gh8018-remove-gen
…d-gh8018-remove-gen
|
The test fixtures removed in this PR -- are they used in the generator tests? If so it may be worth preserving them. We want to thoroughly test the generator, just not to generate tests in the output packages. |

This removes the unit tests from the generator.
I thought this would also cover removing sample tests, but it appears that's already happened.
Fixes #8019 🦕