Skip to content

docs(spanner): update isolation level terminology in comments #15900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prathmeshcc merged 3 commits into from
Jan 23, 2026
Merged

docs(spanner): update isolation level terminology in comments #15900

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b32bfc
docs(spanner): update isolation level terminology in comments
prathmeshcc Jan 22, 2026
3afd8be
Merge branch 'main' into fix/isolation-level-terminology
prathmeshcc Jan 22, 2026
7aeea97
Merge branch 'main' into fix/isolation-level-terminology
prathmeshcc Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/cloud/spanner/transaction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class Transaction {
* absence of conflicts between its updates and any concurrent updates
* that have occurred since that snapshot. Consequently, in contrast to
* `kSerializable` transactions, only write-write conflicts are detected in
* snapshot transactions.
* repeatable read transactions.
*/
kRepeatableRead,
};
Expand Down
4 changes: 2 additions & 2 deletions google/cloud/spanner/transaction_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ TEST(Transaction, IsolationLevelPrecedence) {
return 0;
});

// Case 2: Fallback to client default
// Case 2: Fallback to default options
auto opts_default = Transaction::ReadWriteOptions();
Transaction txn_default = MakeReadWriteTransaction(opts_default);
spanner_internal::Visit(
Expand All @@ -202,7 +202,7 @@ TEST(Transaction, IsolationLevelPrecedence) {
}

TEST(Transaction, IsolationLevelNotSpecified) {
// Case: Isolation not specified in transaction level or client level
// Case: Isolation not specified in transaction options or default options
auto opts = Transaction::ReadWriteOptions();
Transaction txn = MakeReadWriteTransaction(opts);
spanner_internal::Visit(
Expand Down