Skip to content

[anneal][v2] Compile merged util module at stack base#3474

Open
mdittmer wants to merge 1 commit into
mainfrom
Ga2l5vkuio57w6b4kafskxw2bg4ri57gr
Open

[anneal][v2] Compile merged util module at stack base#3474
mdittmer wants to merge 1 commit into
mainfrom
Ga2l5vkuio57w6b4kafskxw2bg4ri57gr

Conversation

@mdittmer

@mdittmer mdittmer commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

The v2 stack previously introduced util.rs in a merged PR but declared the module only when the Charon integration started using it. Declare the module as soon as it exists so later PRs can add users without making earlier files look inert.

The temporary dead_code allowance is needed because this bottom-of-stack commit only wires in the module; subsequent generate/Charon changes remove the allowance once the utilities have production call sites.


Latest Update: v3 — Compare vs v2

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v2 v1 Base
v3 vs v2 vs v1 vs Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/Ga2l5vkuio57w6b4kafskxw2bg4ri57gr && git checkout -b pr-Ga2l5vkuio57w6b4kafskxw2bg4ri57gr FETCH_HEAD

Checkout

git fetch origin refs/heads/Ga2l5vkuio57w6b4kafskxw2bg4ri57gr && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/Ga2l5vkuio57w6b4kafskxw2bg4ri57gr && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/Ga2l5vkuio57w6b4kafskxw2bg4ri57gr

Stacked PRs enabled by GHerrit.

@codecov-commenter

codecov-commenter commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.85%. Comparing base (a986089) to head (2718a00).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3474   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          20       20           
  Lines        6093     6093           
=======================================
  Hits         5597     5597           
  Misses        496      496           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The v2 stack previously introduced util.rs in a merged PR but declared the module only when the Charon integration started using it. Declare the module as soon as it exists so later PRs can add users without making earlier files look inert.

The temporary dead_code allowance is needed because this bottom-of-stack commit only wires in the module; subsequent generate/Charon changes remove the allowance once the utilities have production call sites.

gherrit-pr-id: Ga2l5vkuio57w6b4kafskxw2bg4ri57gr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants