Skip to content

[fix] Allow platform chat namespace in post-transform smoke tests #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
travis-hoover-glean wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

[fix] Allow platform chat namespace in post-transform smoke tests #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/post_transform_smoke.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,12 @@
group: 'search',
nameOverride: 'query',
},
{
path: '/api/chat',
method: 'post',
group: 'chat',
nameOverride: 'create',
},
];

for (const { path, method, group, nameOverride } of platformOps) {
Expand All @@ -190,7 +196,7 @@
expect(
operation,
`expected operation ${method.toUpperCase()} ${path}`,
).toBeDefined();

Check failure on line 199 in tests/post_transform_smoke.test.js

View workflow job for this annotation

GitHub Actions / test

tests/post_transform_smoke.test.js > Post-transformation smoke tests > Platform operations land under expected SDK groups 

AssertionError: expected operation POST /api/chat: expected undefined to be defined
 ❯ tests/post_transform_smoke.test.js:199:9
expect(operation['x-speakeasy-group']).toBe(group);
expect(operation['x-speakeasy-name-override']).toBe(nameOverride);
expect(operation['x-glean-sdk']).toBeUndefined();
Expand Down Expand Up @@ -222,7 +228,7 @@
// without a group silently falls back to its `tags` and leaks a method to
// the SDK top level. The top level is reserved for the Platform API, so
// client/indexing operations must be nested under `client.*` / `indexing.*`.
const platformSegments = new Set(['agents', 'search', 'skills']);
const platformSegments = new Set(['agents', 'chat', 'search', 'skills']);
const allowedTopLevelSegments = new Set([
'client',
'indexing',
Expand Down
Loading