[fix] Allow platform chat namespace in post-transform smoke tests - #141
Open
travis-hoover-glean wants to merge 1 commit into
Open
[fix] Allow platform chat namespace in post-transform smoke tests#141travis-hoover-glean wants to merge 1 commit into
travis-hoover-glean wants to merge 1 commit into
Conversation
The new Platform API POST /api/chat endpoint uses x-speakeasy-group chat, which is a valid top-level SDK namespace alongside agents, search, and skills.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #140 fixed the missing
x-speakeasy-groupoverlays for two new client API endpoints, but CI still fails on a separate issue: the new Platform APIPOST /api/chatendpoint usesx-speakeasy-group: chat, which the smoke test did not recognize as an allowed top-level SDK namespace.This updates the post-transformation smoke test to treat
chatas a valid Platform API namespace (alongsideagents,search, andskills) and adds an explicit assertion for the new endpoint.Failing run: https://github.com/gleanwork/open-api/actions/runs/31036664766/job/92410356368
Test plan
pnpm exec vitest run tests/post_transform_smoke.test.jslocally after regenerating the merged spec