update from net472 to net8.0 on windows#2286
Closed
agollivermsft wants to merge 1 commit intogit-ecosystem:mainfrom
Closed
update from net472 to net8.0 on windows#2286agollivermsft wants to merge 1 commit intogit-ecosystem:mainfrom
agollivermsft wants to merge 1 commit intogit-ecosystem:mainfrom
Conversation
agollivermsft
force-pushed
the
update-to-dotnet8.0
branch
from
5f5475f to
2451727
Compare
Contributor
|
How does this PR relate to/conflict with #1418? |
Contributor
Sadly we are not able to accept this PR at this time to move from .NET Framework on Windows. We have some issues with supporting older Windows versions that we must first resolve. We are hopeful however to drop .NET Framework this year! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on #2285 (fix ambiguous call to string.Split) I saw a compile difference between windows and linux, which seemed to be caused by a mismatch between their target frameworks.
So I search and replaced
net472withnet8.0and simplified some of the logic in the.csprojfiles.No idea if this is the right thing to do, or if any more work needs to be done, but the CI for my original PR seems to finish without issues now.