fix ambiguous call to string.Split#2285
Closed
agollivermsft wants to merge 2 commits intogit-ecosystem:mainfrom
Closed
fix ambiguous call to string.Split#2285agollivermsft wants to merge 2 commits intogit-ecosystem:mainfrom
agollivermsft wants to merge 2 commits intogit-ecosystem:mainfrom
Conversation
Contributor
Author
|
hmm... so now it works on my ubuntu machine (and linux CI generally), but not on windows. Curious. |
e324757 to
c8dff36
Compare
3 tasks
c8dff36 to
4df2a9b
Compare
Contributor
|
This has bene addressed in #2287 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEPENDS ON: #2286 (update from net472 to net8.0 on windows)
On an Ubuntu 24.04 image I get from work
./src/linux/Packaging.Linux/install-from-source.shfails withI don't know much C#, but this change got it to compile & it seems to work locally (I was able to use g-c-m installed from this branch to push this PR, at least)