test(openai-agents): Replace mocks with httpx in MCP tool tests#5605
Open
alexander-alderman-webb wants to merge 2 commits intomasterfrom
Open
test(openai-agents): Replace mocks with httpx in MCP tool tests#5605alexander-alderman-webb wants to merge 2 commits intomasterfrom
httpx in MCP tool tests#5605alexander-alderman-webb wants to merge 2 commits intomasterfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Openai Agents
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 52 passed | Total: 52 | Pass Rate: 100% | Execution Time: 6.70s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 14816 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 25.65% 25.64% -0.01%
==========================================
Files 189 189 —
Lines 19924 19924 —
Branches 6458 6458 —
==========================================
+ Hits 5111 5108 -3
- Misses 14813 14816 +3
- Partials 431 430 -1Generated by Codecov Action |
httpx in MCP tool tests
ericapisani
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace mocks with
httpxtypes to avoid test failures when library internals change.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)