WIP: perf(crashpad): Send event updates over IPC#1841
Open
jpnurmi wants to merge 5 commits into
Open
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Send event updates over IPC ([#1841](https://github.com/getsentry/sentry-native/pull/1841))If none of the above apply, you can opt out of this check by adding |
jpnurmi
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Send serialized crash event and external crash report data to the Crashpad handler for file writes. Keep the existing file-write fallback for payloads that cannot be sent through the handler IPC. Co-Authored-By: OpenAI Codex <noreply@openai.com>
jpnurmi
force-pushed
the
jpnurmi/feat/crashpad-ipz
branch
from
6887029 to
ed18914
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ed18914. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
WIP 🚧🔨⏳⛔
A simpler alternative to #1840 - needs to be combined with #1794.
Pass crash event, breadcrumbs, and external crash report to the Crashpad client and let it decide between direct file-writes (Unix) or IPC (Windows).