WIP: perf(crashpad): Send incremental event updates over IPC#1840
Open
jpnurmi wants to merge 14 commits into
Open
WIP: perf(crashpad): Send incremental event updates over IPC#1840jpnurmi wants to merge 14 commits into
jpnurmi wants to merge 14 commits into
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Send incremental event updates over IPC ([#1840](https://github.com/getsentry/sentry-native/pull/1840))If none of the above apply, you can opt out of this check by adding |
fe2cef2 to
e86dc4c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8f67bc1. Configure here.
8f67bc1 to
1f4e5fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Warning
WIP 🚧🔨⏳⛔
The Crashpad backend now writes a small initial
__sentry-eventand mirrors scope changes to the Crashpad handler as MessagePack updates. This avoids rewriting the full event and external crash report on every scope mutation, which is especially expensive on Windows.sentry_set_tagsentry_add_breadcrumb*) avg +/- stddev [min..max]
Breadcrumbs and attachments are sent through the new scope observer path while preserving the existing breadcrumb rotation. Crash events are still assembled as
__sentry-event; Crashpad merges the accumulated handler-side scope state when the report is written.