-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(core): Improve message truncation for multimodal content and normalize streaming span names #19500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix(core): Improve message truncation for multimodal content and normalize streaming span names #19500
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fac656c
fix(core): Improve message truncation for multimodal content and norm…
RulaKhaled fae419d
take out media stripping to its own file
RulaKhaled 25c9a93
we should fit truncation in 20KB
RulaKhaled 7511263
fix test
RulaKhaled 598e46a
quick refactor
RulaKhaled File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101 changes: 101 additions & 0 deletions
101
dev-packages/node-integration-tests/suites/tracing/openai/scenario-vision.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| import * as Sentry from '@sentry/node'; | ||
| import express from 'express'; | ||
| import OpenAI from 'openai'; | ||
|
|
||
| function startMockServer() { | ||
| const app = express(); | ||
| app.use(express.json({ limit: '10mb' })); | ||
|
|
||
| app.post('/openai/chat/completions', (req, res) => { | ||
| res.send({ | ||
| id: 'chatcmpl-vision-123', | ||
| object: 'chat.completion', | ||
| created: 1677652288, | ||
| model: req.body.model, | ||
| choices: [ | ||
| { | ||
| index: 0, | ||
| message: { | ||
| role: 'assistant', | ||
| content: 'I see a red square in the image.', | ||
| }, | ||
| finish_reason: 'stop', | ||
| }, | ||
| ], | ||
| usage: { | ||
| prompt_tokens: 50, | ||
| completion_tokens: 10, | ||
| total_tokens: 60, | ||
| }, | ||
| }); | ||
| }); | ||
|
|
||
| return new Promise(resolve => { | ||
| const server = app.listen(0, () => { | ||
| resolve(server); | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| // Small 10x10 red PNG image encoded as base64 | ||
| const RED_PNG_BASE64 = | ||
| 'iVBORw0KGgoAAAANSUhEUgAAAAoAAAAKCAYAAACNMs+9AAAAFUlEQVR42mP8z8BQDwADhQGAWjR9awAAAABJRU5ErkJggg=='; | ||
|
|
||
| async function run() { | ||
| const server = await startMockServer(); | ||
|
|
||
| await Sentry.startSpan({ op: 'function', name: 'main' }, async () => { | ||
| const client = new OpenAI({ | ||
| baseURL: `http://localhost:${server.address().port}/openai`, | ||
| apiKey: 'mock-api-key', | ||
| }); | ||
|
|
||
| // Vision request with inline base64 image | ||
| await client.chat.completions.create({ | ||
| model: 'gpt-4o', | ||
| messages: [ | ||
| { | ||
| role: 'user', | ||
| content: [ | ||
| { type: 'text', text: 'What is in this image?' }, | ||
| { | ||
| type: 'image_url', | ||
| image_url: { | ||
| url: `data:image/png;base64,${RED_PNG_BASE64}`, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| }); | ||
|
|
||
| // Vision request with multiple images (one inline, one URL) | ||
| await client.chat.completions.create({ | ||
| model: 'gpt-4o', | ||
| messages: [ | ||
| { | ||
| role: 'user', | ||
| content: [ | ||
| { type: 'text', text: 'Compare these images' }, | ||
| { | ||
| type: 'image_url', | ||
| image_url: { | ||
| url: `data:image/png;base64,${RED_PNG_BASE64}`, | ||
| }, | ||
| }, | ||
| { | ||
| type: 'image_url', | ||
| image_url: { | ||
| url: 'https://example.com/image.png', | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| ], | ||
| }); | ||
| }); | ||
|
|
||
| server.close(); | ||
| } | ||
|
|
||
| run(); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.