fix(core): Improve message truncation for multimodal content and normalize streaming span names#19500
Merged
RulaKhaled merged 5 commits intodevelopfrom Feb 26, 2026
Merged
fix(core): Improve message truncation for multimodal content and normalize streaming span names#19500RulaKhaled merged 5 commits intodevelopfrom
RulaKhaled merged 5 commits intodevelopfrom
Conversation
…alize streaming span names
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
nicohrubec
reviewed
Feb 26, 2026
| ('type' in part && (part.type === 'blob' || part.type === 'base64')) || | ||
| 'b64_json' in part || | ||
| ('type' in part && 'result' in part && part.type === 'image_generation') || | ||
| ('uri' in part && typeof part.uri === 'string' && part.uri.startsWith('data:')) |
Member
There was a problem hiding this comment.
m: could we refactor these into some more helpers or add some kind of explanation what we check with these cases here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces some fixes across AI integrations.
Normalize streaming span description
Removes the stream-response suffix from span descriptions across OpenAI, Anthropic, and Google GenAI integrations. Streaming and non-streaming spans now use the same naming format (e.g., chat gpt-4 instead of chat gpt-4 stream-response), making grouping and filtering more consistent.
Expand multimodal media stripping
Adds detection and redaction of three additional inline media formats in truncateGenAiMessages:
Rename redaction placeholder
Changes the placeholder for stripped binary data from [Filtered] to [Blob substitute] to better communicate what happened.
Fix off-by-one in truncation byte accounting
Subtracts the 2-byte JSON array wrapper ([ and ]) from the effective max bytes budget, and fixes a boundary condition in truncateTextByBytes to avoid strings that land exactly on the byte limit.
Closes #19496 #19479