-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs: Add distributed tracing for RPC in Cloudflare #17541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+72
−2
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
eeac6a8
docs: Add distributed tracing for RPC in Cloudflare
JPeer264 fcaa374
Update platform-includes/distributed-tracing/how-to-use/javascript.cl…
JPeer264 5d0ae0e
Update platform-includes/distributed-tracing/how-to-use/javascript.cl…
JPeer264 2c4b331
Apply suggestion from @JPeer264
JPeer264 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 changes: 67 additions & 1 deletion
68
platform-includes/distributed-tracing/how-to-use/javascript.cloudflare.mdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The
<AvailableSince>tag forenableRpcTracePropagationincorrectly states version10.52.0instead of the correct version10.51.0.Severity: LOW
Suggested Fix
Update the
<AvailableSince>tag injavascript.cloudflare.mdxto reflect the correct version. Change<AvailableSince version="10.52.0" />to<AvailableSince version="10.51.0" />.Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.