docs: Add distributed tracing for RPC in Cloudflare#17541
Open
docs: Add distributed tracing for RPC in Cloudflare#17541
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
s1gr1d
approved these changes
May 4, 2026
Member
s1gr1d
left a comment
There was a problem hiding this comment.
Looks good! Just two text suggestions :)
…oudflare.mdx Co-authored-by: Sigrid <32902192+s1gr1d@users.noreply.github.com>
…oudflare.mdx Co-authored-by: Sigrid <32902192+s1gr1d@users.noreply.github.com>
JPeer264
commented
May 11, 2026
|
|
||
| ### RPC Trace Propagation | ||
|
|
||
| <AvailableSince version="10.52.0" /> |
Contributor
There was a problem hiding this comment.
Bug: The <AvailableSince> tag for enableRpcTracePropagation incorrectly states version 10.52.0 instead of the correct version 10.51.0.
Severity: LOW
Suggested Fix
Update the <AvailableSince> tag in javascript.cloudflare.mdx to reflect the correct version. Change <AvailableSince version="10.52.0" /> to <AvailableSince version="10.51.0" />.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: platform-includes/distributed-tracing/how-to-use/javascript.cloudflare.mdx#L7
Potential issue: The documentation file `javascript.cloudflare.mdx` specifies that the
`enableRpcTracePropagation` feature is available since version `10.52.0`. However,
according to the pull request description and the sentry-javascript changelog, full
support for this feature was introduced in version `10.51.0`. This discrepancy will
mislead users on version `10.51.0`, making them believe they need to upgrade
unnecessarily to use the feature.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
This documents the
enableRpcTracePropagationoption which was implemented over time. Full support started from v10.51.0 (which is currently getting released)IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES