feat(menubar): add macOS app icon#455
Merged
Merged
Conversation
Adds assets/menubar-logo.png and generates AppIcon.icns (all standard sizes via sips + iconutil) in package-app.sh, so the menubar app ships with a real icon instead of the generic one. Info.plist already referenced AppIcon. Icon and bundler change from @tvcsantos's #439; the unrelated tsconfig.json change in that PR was left out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a real macOS app icon for the menubar app.
assets/menubar-logo.png(750x750).mac/Scripts/package-app.shgeneratesAppIcon.icnsat all standard sizes (sips + iconutil) and copies it into the bundle Resources. Info.plist already referencedCFBundleIconFile = AppIcon, but nothing produced the icns, so the app shipped with the generic icon until now.This is the icon and bundler change from @tvcsantos's #439. I left out the unrelated
tsconfig.json"types": ["node"]change from that PR (it is not needed and is a project-wide change), to keep this scoped to just the icon. #439 can be closed in favor of this.Verified:
package-app.shbuilds a bundle containingAppIcon.icns(Info.plist references AppIcon). No TypeScript or test changes.