feat: add missing mac app icon#439
Closed
tvcsantos wants to merge 1 commit into
Closed
Conversation
tvcsantos
force-pushed
the
feature/add-app-icon
branch
from
b86c0ed to
0e6b267
Compare
iamtoruk
added a commit
that referenced
this pull request
Jun 6, 2026
Adds assets/menubar-logo.png and generates AppIcon.icns (all standard sizes via sips + iconutil) in package-app.sh, so the menubar app ships with a real icon instead of the generic one. Info.plist already referenced AppIcon. Icon and bundler change from @tvcsantos's #439; the unrelated tsconfig.json change in that PR was left out.
Member
|
Thanks for the icon. Landed it on main in #455, crediting you. The only thing I left out was the unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On mac, the app was missing an icon. This PR adresses that issue and adds the missing icon, using the flame asset already in resources with a white background and no text. Just the flame.
Also added a small fix for linting issues by adding the missing types: ['node'] on tsconfig.
Testing
npm testpassesnpm run buildsucceedsFor new providers only:
npm run dev -- todayshows correct costs and session counts for this providernpm run dev -- models --provider <name>shows correct model names and pricing