Skip to content

fix: sidebar navigation, result panel icons, DataGrid row selection and actions #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Blankll merged 4 commits into from
Jul 28, 2026
Merged

fix: sidebar navigation, result panel icons, DataGrid row selection and actions #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b267e4
fix: sidebar navigation click handler not calling navigate
Blankll Jul 28, 2026
af432c6
ui: unify result panel icons with editor toolbar style
Blankll Jul 28, 2026
266ecf0
fix: DataGrid row selection only via checkbox, actions always visible
Blankll Jul 28, 2026
e437b95
chore: update Cargo.lock
Blankll Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src-tauri/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 13 additions & 13 deletions src/components/database-browser/QueryResultPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,8 @@ const displayExecutionTime = computed(() => gridExecutionTimeMs.value ?? props.e
<TooltipProvider>
<Tooltip>
<TooltipTrigger as-child>
<Button variant="ghost" size="sm" class="text-foreground p-0 h-8 w-8 hover:bg-muted" @click="copyUtil.copyRowsAs(displayResults.rows, displayResults.columns, 'csv')">
<span class="i-carbon-table-split h-4.5 w-4.5" />
<Button variant="ghost" size="icon" class="text-sky-600 h-7 w-7 dark:text-sky-400 hover:bg-sky-500/10 dark:hover:bg-sky-500/20" @click="copyUtil.copyRowsAs(displayResults.rows, displayResults.columns, 'csv')">
<span class="i-lucide-file-spreadsheet shrink-0 h-3.5 w-3.5" />
</Button>
</TooltipTrigger>
<TooltipContent>{{ t('components.dataGrid.export.copyAllCsv') }}</TooltipContent>
Expand All @@ -267,8 +267,8 @@ const displayExecutionTime = computed(() => gridExecutionTimeMs.value ?? props.e
<TooltipProvider>
<Tooltip>
<TooltipTrigger as-child>
<Button variant="ghost" size="sm" class="text-foreground p-0 h-8 w-8 hover:bg-muted" @click="copyUtil.copyRowsAs(displayResults.rows, displayResults.columns, 'json')">
<span class="i-carbon-code h-4.5 w-4.5" />
<Button variant="ghost" size="icon" class="text-amber-600 h-7 w-7 dark:text-amber-400 hover:bg-amber-500/10 dark:hover:bg-amber-500/20" @click="copyUtil.copyRowsAs(displayResults.rows, displayResults.columns, 'json')">
<span class="i-lucide-file-json shrink-0 h-3.5 w-3.5" />
</Button>
</TooltipTrigger>
<TooltipContent>{{ t('components.dataGrid.export.copyAllJson') }}</TooltipContent>
Expand All @@ -277,19 +277,19 @@ const displayExecutionTime = computed(() => gridExecutionTimeMs.value ?? props.e
<TooltipProvider>
<Tooltip>
<TooltipTrigger as-child>
<Button variant="ghost" size="sm" class="text-foreground p-0 h-8 w-8 hover:bg-muted" @click="copyUtil.copyRowsAs(displayResults.rows, displayResults.columns, 'insert')">
<span class="i-carbon-sql h-4.5 w-4.5" />
<Button variant="ghost" size="icon" class="text-emerald-600 h-7 w-7 dark:text-emerald-400 hover:bg-emerald-500/10 dark:hover:bg-emerald-500/20" @click="copyUtil.copyRowsAs(displayResults.rows, displayResults.columns, 'insert')">
<span class="i-lucide-database shrink-0 h-3.5 w-3.5" />
</Button>
</TooltipTrigger>
<TooltipContent>{{ t('components.dataGrid.export.copyAllInsert') }}</TooltipContent>
</Tooltip>
</TooltipProvider>
<span class="text-xs text-muted-foreground mx-1">|</span>
<div class="mx-0.5 bg-border h-4 w-px" />
<TooltipProvider>
<Tooltip>
<TooltipTrigger as-child>
<Button variant="ghost" size="sm" class="text-foreground p-0 h-8 w-8 hover:bg-muted" @click="copyUtil.exportToFile(displayResults.rows, displayResults.columns, 'csv')">
<span class="i-carbon-document-export h-4.5 w-4.5" />
<Button variant="ghost" size="icon" class="text-sky-600 h-7 w-7 dark:text-sky-400 hover:bg-sky-500/10 dark:hover:bg-sky-500/20" @click="copyUtil.exportToFile(displayResults.rows, displayResults.columns, 'csv')">
<span class="i-lucide-file-down shrink-0 h-3.5 w-3.5" />
</Button>
</TooltipTrigger>
<TooltipContent>{{ t('components.dataGrid.export.exportCsv') }}</TooltipContent>
Expand All @@ -298,8 +298,8 @@ const displayExecutionTime = computed(() => gridExecutionTimeMs.value ?? props.e
<TooltipProvider>
<Tooltip>
<TooltipTrigger as-child>
<Button variant="ghost" size="sm" class="text-foreground p-0 h-8 w-8 hover:bg-muted" @click="copyUtil.exportToFile(displayResults.rows, displayResults.columns, 'json')">
<span class="i-carbon-document-export h-4.5 w-4.5" />
<Button variant="ghost" size="icon" class="text-amber-600 h-7 w-7 dark:text-amber-400 hover:bg-amber-500/10 dark:hover:bg-amber-500/20" @click="copyUtil.exportToFile(displayResults.rows, displayResults.columns, 'json')">
<span class="i-lucide-file-down shrink-0 h-3.5 w-3.5" />
</Button>
</TooltipTrigger>
<TooltipContent>{{ t('components.dataGrid.export.exportJson') }}</TooltipContent>
Expand All @@ -315,11 +315,11 @@ const displayExecutionTime = computed(() => gridExecutionTimeMs.value ?? props.e
<Button
variant="ghost"
size="icon"
class="h-6 w-6"
class="text-muted-foreground h-7 w-7 hover:text-foreground"
:title="t('components.queryResult.close')"
@click="close"
>
<span class="i-carbon-close h-3.5 w-3.5" />
<span class="i-lucide-x shrink-0 h-3.5 w-3.5" />
</Button>
</div>

Expand Down
3 changes: 1 addition & 2 deletions src/components/grid/DataGrid.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,6 @@ watch(() => [props.rows, props.columns], () => {
:class="getCellClass(columnTypes?.[col])"
:style="{ width: `${getColumnWidth(col)}px` }"
:title="getCellTooltip(rows[virtualRow.index][col])"
@click="selection.toggleRow(virtualRow.index, false)"
@contextmenu.prevent="openCellContextMenu($event, virtualRow.index, col)"
>
<!-- NULL -->
Expand Down Expand Up @@ -695,7 +694,7 @@ watch(() => [props.rows, props.columns], () => {
<!-- Row Actions -->
<div
v-if="connectionId"
class="bg-background/80 opacity-0 flex flex-shrink-0 w-10 transition-opacity items-center right-0 justify-center sticky z-10 group-hover:opacity-100"
class="bg-background/80 flex flex-shrink-0 w-10 items-center right-0 justify-center sticky z-10"
@click.stop
>
<DropdownMenu>
Expand Down
2 changes: 1 addition & 1 deletion src/components/layout/AppSidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const { t } = useI18n()
? 'bg-secondary text-primary border border-border shadow-sm'
: 'text-muted-foreground hover:bg-secondary hover:text-foreground',
]"
@click="item.id === 'github' ? openUrl('https://github.com/geek-fun/sqlkit') : navigate"
@click="item.id === 'github' ? openUrl('https://github.com/geek-fun/sqlkit') : navigate()"
>
<!-- DNS icon -->
<svg
Expand Down
Loading