fix: sidebar navigation, result panel icons, DataGrid row selection and actions - #122
Merged
Conversation
Ternary expression returned navigate function reference without invoking it. Vue 3 compiles simple @click='navigate' as => navigate(), but complex expressions like 'condition ? fn() : navigate' evaluate to the function without calling it. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Match editor toolbar patterns: colored semantic icons (sky/amber/emerald), h-7 w-7 buttons, h-3.5 w-3.5 icon sizes, i-lucide icon set, proper divider, consistent hover effects. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Removed @click toggleRow from data cells so selection only triggers from checkbox. Removed opacity-0/group-hover from actions column so Edit/Delete menu is always visible. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three UI issues and one visual polish pass.
Changes
Sidebar Navigation
Vue 3 compiles simple @click="navigate" correctly, but complex expressions like
condition ? fn() : navigateevaluate to the function without calling it. Changed to navigate().Result Panel Icons
DataGrid