Fix callTool() crash on JSON-RPC error responses#9
Merged
frouaix merged 2 commits intoissue-1-e2e-testingfrom Feb 22, 2026
Merged
Fix callTool() crash on JSON-RPC error responses#9frouaix merged 2 commits intoissue-1-e2e-testingfrom
frouaix merged 2 commits intoissue-1-e2e-testingfrom
Conversation
Co-authored-by: frouaix <876178+frouaix@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update E2E tests based on feedback from PR #1
Fix callTool() crash on JSON-RPC error responses
Feb 22, 2026
frouaix
approved these changes
Feb 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash in the callTool() test helper function when the MCP server returns a JSON-RPC error response. Previously, the function unconditionally accessed response["result"]["content"], which would throw if the server returned a JSON-RPC error object (response["error"]) instead. This masked the real error and broke test determinism.
Changes:
- Added early-return error handling in
callTool()to check forresponse["error"]before accessingresponse["result"] - Error responses are now returned with a structured
{ isError: true, text, parsed, raw }format, consistent with application-level errors - Both JSON-RPC protocol errors and application-level
isErrorresults surface consistently through the sameisErrorsignal
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frouaix
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
callTool()unconditionally accessedresponse["result"]["content"], throwing if the server returned a JSON-RPC error object (response["error"]) instead of a result — masking the real error and breaking test determinism.Changes
e2e-apps.test.ts—callTool()error handling: Added early-return branch forresponse["error"], returning a structured{ isError: true, text, parsed, raw }instead of throwing:Both JSON-RPC-level errors and application-level
isErrorresults now surface consistently through the sameisErrorsignal.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.