Conversation
- Add 45 E2E tests in e2e-apps.test.ts covering: - System tools (ping, get_mode) - Readonly operations for all 10 apps (list_containers, list, search) - Create/action with dryRun=true for 6 apps - Error paths (invalid app, create in readonly mode) - Fix existing server.test.ts to use current generic app.* tool names - Fix TypeScript strict errors in safari.ts (parts[0] nullability) - No destructive operations tested (update, delete, run_script) Closes #1 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds end-to-end integration coverage for the MCP server’s Apple app adapters by spawning the real server and exercising the JSON-RPC tool pipeline end-to-end, plus aligns existing integration tests and fixes a Safari adapter strictness issue.
Changes:
- Added a new integration E2E suite covering readonly tools across all 10 supported apps and dry-run create/action flows for a subset.
- Updated
server.test.tsassertions to match the current tool surface and server version. - Fixed
SafariAdapterstrict-mode nullability around parsing tab index.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/mcp-server/test/integration/server.test.ts | Updates integration assertions for current tool names, tool counts, and ping version. |
| packages/mcp-server/test/integration/e2e-apps.test.ts | Introduces a full-pipeline E2E suite that spawns the server and calls app tools via JSON-RPC over stdio. |
| packages/mcp-server/src/adapters/safari.ts | Fixes strict-mode nullability when parsing parts[0] for tab index. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The lockfile was generated with pnpm 10 (lockfileVersion 9.0) but CI was pinned to pnpm 8, causing 'not compatible lockfile' errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Contributor
Contributor
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…eout, unref timer Co-authored-by: frouaix <876178+frouaix@users.noreply.github.com>
Co-authored-by: frouaix <876178+frouaix@users.noreply.github.com>
Co-authored-by: frouaix <876178+frouaix@users.noreply.github.com>
Fix timeout and listener leaks in `readResponseById`
Gate E2E tests behind APPLESCRIPT_E2E flag; auto-skip in CI
Fix callTool() crash on JSON-RPC error responses
- Add @eslint/js and globals to devDependencies - Add Node.js globals to eslint config (process, Buffer, setTimeout, etc.) - Ignore dist/ directory in eslint - Remove unused project option from parser (test files not in tsconfig) - Disable base no-unused-vars (handled by @typescript-eslint version) - Fix unused beforeEach import in server.test.ts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive end-to-end tests for all 10 Apple app adapters, exercising the full server pipeline (MCP server → adapter → Swift executor).
Changes
e2e-apps.test.ts— 45 tests covering:dryRun=truefor 6 apps (Notes, Calendar, Reminders, Mail, Contacts, Safari)server.test.ts— Updated stale tool names (notes.create_note→app.create, etc.) and tool count assertions (4 → 7 readonly tools)safari.ts— Resolve TypeScript strict-mode errors (parts[0]nullability)Test results
Scope
Closes #1