Widen base-client dependency to 0.12.0#171
Merged
Marenz merged 3 commits intofrequenz-floss:v0.x.xfrom May 27, 2025
Merged
Conversation
github-actions
bot
added
part:tooling
There was a problem hiding this comment.
Pull Request Overview
This PR widens the version range for the frequenz-client-base dependency to support upcoming stream-reconnect features.
- Updated dependency version requirement in pyproject.toml
- Ensures compatibility with future base client enhancements
Comments suppressed due to low confidence (1)
pyproject.toml:41
- Widening the dependency range may introduce unexpected changes in the base client's API. Please ensure that integration tests cover any breaking changes or new behaviors introduced in versions between 0.10.0 and 0.12.0.
"frequenz-client-base >= 0.8.0, < 0.12.0",
This comment was marked as outdated.
This comment was marked as outdated.
llucax
reviewed
May 27, 2025
Contributor
llucax
left a comment
llucax
left a comment
There was a problem hiding this comment.
Maybe split in 3 commits?
In anticipation of the stream-reconnect feature in the base client. Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In anticipation of the stream-reconnect feature in the base client.