Fetch dispatches in sync with periodic reconnect of client.stream#155
Merged
Marenz merged 4 commits intofrequenz-floss:v0.x.xfrom Jun 25, 2025
Merged
Fetch dispatches in sync with periodic reconnect of client.stream#155Marenz merged 4 commits intofrequenz-floss:v0.x.xfrom
Marenz merged 4 commits intofrequenz-floss:v0.x.xfrom
Conversation
github-actions
bot
added
part:docs
llucax
reviewed
May 22, 2025
Marenz
force-pushed
the
periodic-event-check
branch
from
ba62a7a to
a79b3e3
Compare
github-actions
bot
added
the
part:tooling
Marenz
changed the title
Marenz
added
the
status:blocked
Contributor
Author
Marenz
force-pushed
the
periodic-event-check
branch
from
a79b3e3 to
b5aff78
Compare
Contributor
ela-kotulska-frequenz
left a comment
ela-kotulska-frequenz
left a comment
There was a problem hiding this comment.
LGTM, only needs rebasing :)
Contributor
Author
Unfortunately, using a new base-client also means allowing a new base client version in microclient, so we will have to release both base-client and microclient |
Contributor
|
"microclient" 😆 |
llucax
reviewed
Jun 2, 2025
Marenz
force-pushed
the
periodic-event-check
branch
from
b5aff78 to
59eb1b3
Compare
Marenz
force-pushed
the
periodic-event-check
branch
from
59eb1b3 to
bb61120
Compare
github-actions
bot
added
the
part:tests
llucax
reviewed
Jun 13, 2025
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Marenz
force-pushed
the
periodic-event-check
branch
from
bb61120 to
300abeb
Compare
Marenz
force-pushed
the
periodic-event-check
branch
from
300abeb to
571373d
Compare
To ensure we didn't miss any. Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Marenz
force-pushed
the
periodic-event-check
branch
from
571373d to
fa4ab8e
Compare
Contributor
Author
|
This is now ready |
Marenz
removed
the
status:blocked
llucax
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should probably use
frequenz-floss/frequenz-client-base-python#141
eventually to be less hacky?