fix: treat rate limiter deadline as a context deadline #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no dedicated error type for rate limiter "would exceed context deadline" error, hence we check the error message https://cs.opensource.google/go/x/time/+/refs/tags/v0.10.0:rate/rate.go;l=276 Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
force-pushed
the
backport-upstream-635
branch
from
a7dae11 to
5288f56
Compare
stefanprodan
approved these changes
Jan 9, 2026
matheuscscp
added a commit
to fluxcd/pkg
that referenced
this pull request
Jan 29, 2026
The workaround filtered out DeadlineExceeded errors from lastStatus updates to prevent kstatus from polluting timeout error messages with all monitored resources. This is no longer needed since cli-utils v0.37.1-flux.1 (fluxcd/cli-utils#18) properly recognizes rate limiter deadline errors as cancellation signals. Add TestWaitForSet_RateLimiterError to verify that rate limiter errors no longer cause all resources to appear in the timeout error message. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
matheuscscp
added a commit
to fluxcd/pkg
that referenced
this pull request
Jan 29, 2026
The workaround filtered out DeadlineExceeded errors from lastStatus updates to prevent kstatus from polluting timeout error messages with all monitored resources. This is no longer needed since cli-utils v0.37.1-flux.1 (fluxcd/cli-utils#18) properly recognizes rate limiter deadline errors as cancellation signals. Add TestWaitForSet_RateLimiterError to verify that rate limiter errors no longer cause all resources to appear in the timeout error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting kubernetes-sigs#635 from upstream.
Thanks @levenleven!