ssa: remove DeadlineExceeded workaround in WaitForSetWithContext

The workaround filtered out DeadlineExceeded errors from lastStatus
updates to prevent kstatus from polluting timeout error messages with
all monitored resources. This is no longer needed since cli-utils
v0.37.1-flux.1 (fluxcd/cli-utils#18) properly recognizes rate limiter
deadline errors as cancellation signals.

Add TestWaitForSet_RateLimiterError to verify that rate limiter errors
no longer cause all resources to appear in the timeout error message.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: matheuscscp

ssa/manager_wait.go

@@ -101,12 +101,7 @@ func (m *ResourceManager) WaitForSetWithContext(ctx context.Context, set object.
 				if rs == nil {
 					continue
 				}
-				// skip DeadlineExceeded errors because kstatus emits that error
-				// for every resource it's monitoring even when only one of them
-				// actually fails.
-				if !errors.Is(rs.Error, context.DeadlineExceeded) {
-					lastStatus[rs.Identifier] = rs
-				}
+				lastStatus[rs.Identifier] = rs
 
 				rss = append(rss, rs)
 				counts[rs.Status]++

ssa/manager_wait_test.go

@@ -344,6 +344,73 @@ func TestWaitForSet_terminalState(t *testing.T) {
 	})
 }
 
+func TestWaitForSet_RateLimiterError(t *testing.T) {
+	g := NewWithT(t)
+
+	id := generateName("ratelimit")
+
+	// Create real resources on the cluster: 4 ConfigMaps + 1 PVC.
+	objects, err := readManifest("testdata/test14.yaml", id)
+	g.Expect(err).NotTo(HaveOccurred())
+
+	manager.SetOwnerLabels(objects, "infra", "default")
+	cs, err := manager.ApplyAllStaged(context.Background(), objects, DefaultApplyOptions())
+	g.Expect(err).NotTo(HaveOccurred())
+
+	// Use a custom status reader that returns the rate limiter error
+	// after initial polls. This exercises the real cli-utils error handling
+	// code path (errResourceToResourceStatus / errIdentifierToResourceStatus)
+	// that PR https://github.com/fluxcd/cli-utils/pull/18 fixes.
+	//
+	// On old cli-utils (before PR #18): the rate limiter error is NOT recognized
+	// as cancellation, so it becomes a ResourceStatus with Unknown status for ALL
+	// resources that encounter it. The timeout error message would list every
+	// single resource with "Unknown: rate: Wait(n=1) would exceed context deadline".
+	//
+	// On new cli-utils (with PR #18): the rate limiter error IS recognized as
+	// cancellation via isRateLimiterContextDeadlineExceeded(), so polling stops
+	// cleanly and the error is propagated directly without dumping all resources.
+	var callCount int
+	manager.poller = polling.NewStatusPoller(manager.client, restMapper, polling.Options{
+		CustomStatusReaders: []engine.StatusReader{
+			kstatusreaders.NewGenericStatusReader(restMapper,
+				func(u *unstructured.Unstructured) (*status.Result, error) {
+					callCount++
+					// After a few poll cycles, return the rate limiter error
+					// for every resource. This is the exact error string that
+					// old kstatus failed to handle properly.
+					if callCount > 10 {
+						return nil, fmt.Errorf("rate: Wait(n=1) would exceed context deadline")
+					}
+					// Use the built-in status computation for initial polls.
+					return status.Compute(u)
+				},
+			),
+		},
+	})
+	defer func() {
+		manager.poller = poller
+	}()
+
+	err = manager.WaitForSet(cs.ToObjMetadataSet(), WaitOptions{
+		Interval: 100 * time.Millisecond,
+		Timeout:  2 * time.Second,
+		FailFast: false,
+	})
+
+	g.Expect(err).To(HaveOccurred())
+	errMsg := err.Error()
+	t.Logf("error message: %s", errMsg)
+
+	// With the new cli-utils (PR #18 fix), the rate limiter error should NOT
+	// produce a huge error message with all resources listed as Unknown.
+	for i := 1; i <= 4; i++ {
+		cmName := fmt.Sprintf("%s-cm%d", id, i)
+		g.Expect(errMsg).NotTo(ContainSubstring(cmName),
+			"error should not contain ConfigMap %s — rate limiter errors should not pollute the error message with all resources", cmName)
+	}
+}
+
 func TestWaitForSet_ErrorOnReaderError(t *testing.T) {
 	g := NewWithT(t)
 

ssa/testdata/test14.yaml

@@ -0,0 +1,50 @@
+---
+apiVersion: v1
+kind: Namespace
+metadata:
+  name: "%[1]s"
+---
+apiVersion: v1
+data:
+  foo: bar
+kind: ConfigMap
+metadata:
+  name: "%[1]s-cm1"
+  namespace: "%[1]s"
+---
+apiVersion: v1
+data:
+  foo: bar
+kind: ConfigMap
+metadata:
+  name: "%[1]s-cm2"
+  namespace: "%[1]s"
+---
+apiVersion: v1
+data:
+  foo: bar
+kind: ConfigMap
+metadata:
+  name: "%[1]s-cm3"
+  namespace: "%[1]s"
+---
+apiVersion: v1
+data:
+  foo: bar
+kind: ConfigMap
+metadata:
+  name: "%[1]s-cm4"
+  namespace: "%[1]s"
+---
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+  name: "%[1]s"
+  namespace: "%[1]s"
+spec:
+  storageClassName: manual
+  accessModes:
+    - ReadWriteOnce
+  resources:
+    requests:
+      storage: 3Gi