Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/scripts/plugin_tools_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
set -e

cd script/tool
dart pub run test
dart test
2 changes: 1 addition & 1 deletion packages/go_router/doc/type-safe-routes.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ To build the generated files (ending in .g.dart), use the build_runner command:

```
flutter pub global activate build_runner
flutter pub run build_runner build
dart run build_runner build

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change is correct. For consistency, you might also want to update the preceding line from flutter pub global activate build_runner to dart pub global activate build_runner. The flutter pub commands are generally being replaced by their dart pub equivalents for command-line tooling.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not too familiar with flutter/dart cli, is this comment accurate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's an official view on that. Both commands should work.

```

To navigate, construct a GoRouteData object with the required parameters and
Expand Down
2 changes: 1 addition & 1 deletion packages/pigeon/diff_tool.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ gitTool="git -c advice.detachedHead=false"
generate_everything() {
local inputPath=$1
local outputDir=$2
pub run pigeon \
dart run pigeon \
--input "$inputPath" \
--dart_out "$outputDir/dart.dart" \
--java_out "$outputDir/java.dart" \
Expand Down
Loading