-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Replace pub run with dart run #10849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly replaces deprecated pub run and flutter pub run commands with the modern dart run equivalent across shell scripts, documentation, and source code comments. The changes are accurate and align with the goal of keeping the tooling commands up to date. I have one minor suggestion in a documentation file to further improve consistency.
| ``` | ||
| flutter pub global activate build_runner | ||
| flutter pub run build_runner build | ||
| dart run build_runner build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not too familiar with flutter/dart cli, is this comment accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's an official view on that. Both commands should work.
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, I thought I fixed all of these in the repo a long time ago.
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/packages@e712bfa...e37af11 2026-01-27 sigurdm@google.com Replace pub run with dart run (flutter/packages#10849) 2026-01-26 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.squareup.okhttp3:okhttp from 5.3.1 to 5.3.2 in /packages/espresso/android (flutter/packages#10502) 2026-01-26 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.datastore:datastore from 1.1.7 to 1.2.0 in /packages/shared_preferences/shared_preferences_android/android (flutter/packages#10506) 2026-01-26 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.activity:activity from 1.11.0 to 1.12.2 in /packages/image_picker/image_picker_android/android (flutter/packages#10662) 2026-01-26 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.maps.android:android-maps-utils from 3.20.1 to 4.0.0 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/packages#10888) 2026-01-26 engine-flutter-autoroll@skia.org Manual roll Flutter from def9ca9 to 7165649 (6 revisions) (flutter/packages#10903) 2026-01-26 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.android.gms:play-services-maps from 19.2.0 to 20.0.0 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/packages#10889) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Following up on dart-lang/pub#4737, this PR replaces deprecated
pub runcommands withdart run.