Merged
Conversation
weefuzzy
reviewed
Nov 25, 2025
|
|
||
| using fluid::algorithm::NMFCross; | ||
| using Tensor = fluid::FluidTensor<double, 2>; | ||
| NMFCross algo; |
Member
There was a problem hiding this comment.
Suggested change
| NMFCross algo; | |
| NMFCross algo(2); |
Member
Author
There was a problem hiding this comment.
so the algo is created at each call, with the number of iterations as a constructor variable?
weefuzzy
reviewed
Nov 25, 2025
| Tensor targetMag{{0.5, 0.4}, {0.1, 1.1}, {0.7, 0.8}, {0.3, 0.0}, {1.0, 0.9}, {0.2, 0.6}}; | ||
| Tensor sourceMag{{0.0, 0.4}, {0.6, 0.7}, {0.8, 0.1}, {1.0, 0.5}, {1.1, 0.2}, {0.9, 0.3}}; | ||
|
|
||
| std::vector Hs(3, Tensor(5, 2)); |
Member
There was a problem hiding this comment.
Suggested change
| std::vector Hs(3, Tensor(5, 2)); | |
| std::vector Hs(3, Tensor(6, 6)); |
Algo is getting numFrames from the length of targetMag and the rank from the length of sourceMag
Member
There was a problem hiding this comment.
With those changes, the tests pass for me. Locally, rerun cmake with -DFLUCOMA_TESTS=ON to enable
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first attempt at a first UT in c++... this should work, but my test is from the hip... I'm not certain I test the right thing at the right dims