feat(BETDisk): add collective_pitch field [SCFD-7370]#1938
Merged
benflexcompute merged 2 commits intorelease-candidate/25.9from Mar 27, 2026
Merged
Conversation
Adds an optional `collective_pitch` angle to BETDisk that applies a uniform offset to all blade twist values during solver translation. This allows users to adjust rotor collective pitch directly without modifying BET source files. The field defaults to None and is excluded from serialized JSON via exclude_none, preserving forward compatibility with older SDK versions. Ref: SCFD-7370 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 64988cd0b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ache Ensure collective_pitch persists through multi-constructor round-trips (from_xrotor, from_c81, from_dfdc, from_xfoil) by adding it to: - BETDiskCache - _update_input_cache field validator list - All from_* constructor signatures Updates ref JSON files to include the new nullable field. Ref: SCFD-7370 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
angranl-flex
approved these changes
Mar 27, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collective_pitchfield toBETDiskmodel, allowing users to apply a uniform twist offset to all blades without modifying BET source filesNoneand is excluded from serialized JSON viaexclude_none, preserving forward compatibility with older SDK versionsTest plan
test_betdisk_collective_pitch_offsets_twists— verifies pitch correctly offsets all twist valuestest_betdisk_collective_pitch_none_matches_zero— verifies None produces identical output to no offsettest_betdisk_collective_pitch_excluded_from_serialization_when_none— verifies forward compat (nocollectivePitchkey in JSON when None)Ref: https://flow360.atlassian.net/browse/SCFD-7370
🤖 Generated with Claude Code
Note
Medium Risk
Medium risk because it changes BETDisk translation output by modifying all translated twist angles when
collective_pitchis set, which can affect simulation results; behavior is guarded by an optional field and covered by targeted tests.Overview
Adds an optional
collective_pitchfield toBETDisk(and its input cache and constructors) to represent a uniform pitch offset without modifying source BET files.Updates the solver translator so each translated
twists[].twistvalue is offset bycollective_pitch(defaults to 0 when unset), while keeping solver JSON schema unchanged and ensuringcollective_pitch=Noneremains excluded from serialization.Extends converter reference fixtures and adds tests to validate cache round-tripping and translation behavior for set vs unset pitch.
Written by Cursor Bugbot for commit fcecb67. This will update automatically on new commits. Configure here.