[Hotfix Main]: feat(BETDisk): add collective_pitch field [SCFD-7370]#1939
Merged
benflexcompute merged 1 commit intomainfrom Mar 27, 2026
Merged
[Hotfix Main]: feat(BETDisk): add collective_pitch field [SCFD-7370]#1939benflexcompute merged 1 commit intomainfrom
benflexcompute merged 1 commit intomainfrom
Conversation
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
benflexcompute
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix of PR #1938 (#1938) to the
mainbranch.Hey @benflexcompute, please review this hotfix PR created from your original PR.
Note
Medium Risk
Medium risk because it changes BETDisk-to-solver translation by modifying all translated twist angles, which can affect aerodynamic results; behavior is backward-compatible when
collective_pitchis unset (treated as 0).Overview
Adds an optional
collective_pitchangle toBETDisk(and its input cache) and wires it through allfrom_*constructors.Updates the solver translator so
collective_pitchis applied as a uniform degree offset to every translatedtwists[*].twistvalue (defaults to 0 when unset), and extends reference JSON fixtures plus new tests to verify input-cache persistence and translation behavior/serialization whencollective_pitchisNone.Written by Cursor Bugbot for commit 8e75294. This will update automatically on new commits. Configure here.