Skip to content

[Hotfix Main]: feat(BETDisk): add collective_pitch field [SCFD-7370]#1939

Merged
benflexcompute merged 1 commit intomainfrom
hotfix-main-pr1938
Mar 27, 2026
Merged

[Hotfix Main]: feat(BETDisk): add collective_pitch field [SCFD-7370]#1939
benflexcompute merged 1 commit intomainfrom
hotfix-main-pr1938

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Mar 27, 2026

Hotfix of PR #1938 (#1938) to the main branch.
Hey @benflexcompute, please review this hotfix PR created from your original PR.


Note

Medium Risk
Medium risk because it changes BETDisk-to-solver translation by modifying all translated twist angles, which can affect aerodynamic results; behavior is backward-compatible when collective_pitch is unset (treated as 0).

Overview
Adds an optional collective_pitch angle to BETDisk (and its input cache) and wires it through all from_* constructors.

Updates the solver translator so collective_pitch is applied as a uniform degree offset to every translated twists[*].twist value (defaults to 0 when unset), and extends reference JSON fixtures plus new tests to verify input-cache persistence and translation behavior/serialization when collective_pitch is None.

Written by Cursor Bugbot for commit 8e75294. This will update automatically on new commits. Configure here.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@benflexcompute benflexcompute marked this pull request as ready for review March 27, 2026 20:36
@benflexcompute benflexcompute enabled auto-merge (squash) March 27, 2026 20:36
@benflexcompute benflexcompute merged commit b760665 into main Mar 27, 2026
18 checks passed
@benflexcompute benflexcompute deleted the hotfix-main-pr1938 branch March 27, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant