docs: Clarify dokploy-network is auto-attached by Dokploy#31
Conversation
Document that services not exposed via Cloudflare Tunnel should not declare any network in their compose file — Dokploy attaches its own dokploy-network automatically on deploy. Note traccar's explicit declaration is redundant legacy. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates architectural guidance in CLAUDE.md to clarify Docker network configuration. It specifies that services requiring Cloudflare internet exposure should declare the ChangesNetwork Architecture Guidance
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s contributor/agent guidance (CLAUDE.md) to clarify the intended Docker network convention when deploying services via Dokploy—specifically that services not exposed via the Cloudflare Tunnel should omit explicit network declarations because Dokploy auto-attaches its own network.
Changes:
- Clarifies that Cloudflare-exposed services must explicitly join the
cloudflare-exposednetwork. - Documents that non-exposed services should not declare any network, since Dokploy auto-attaches
dokploy-network. - Notes that
traccar’s explicitdokploy-networkdeclaration is redundant legacy behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Documents a repo convention in
CLAUDE.md: services that don't need Cloudflare Tunnel exposure should not declare any network in their compose file — Dokploy attaches its owndokploy-networkautomatically on deploy (e.g.n8n,plex,watchtower).Surfaced while adding the n8n service (#30), where the network declaration was dropped for this reason. Also notes that
traccar's explicitdokploy-networkdeclaration is redundant legacy.🤖 Generated with Claude Code
Summary by CodeRabbit