Skip to content

[Traccar] Remove redundant dokploy-network declaration#32

Merged
finallyjay merged 1 commit into
mainfrom
traccar-remove-redundant-network
Jun 10, 2026
Merged

[Traccar] Remove redundant dokploy-network declaration#32
finallyjay merged 1 commit into
mainfrom
traccar-remove-redundant-network

Conversation

@finallyjay

@finallyjay finallyjay commented Jun 10, 2026

Copy link
Copy Markdown
Owner

Dokploy attaches its own network automatically on deploy, so explicitly declaring dokploy-network in the compose file is redundant (per the convention documented in #31).

Changes:

  • Remove the service-level networks: [dokploy-network] and the top-level networks: block from traccar/docker-compose.yml.
  • Update traccar/README.md Networks section to match.
  • Move traccar into the example list in CLAUDE.md now that it follows the convention.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation

    • Updated deployment and configuration guidance to clarify that services no longer require explicit network declarations in compose files. Dokploy automatically handles network attachment during deployment, reducing configuration overhead and simplifying setup.
  • Configuration Changes

    • Removed explicit network declarations from service configuration.

Dokploy attaches its own network automatically on deploy, so declaring
dokploy-network in the compose file is redundant. Drop it from the
traccar service and update its README. Also fold traccar into the list
of examples in CLAUDE.md now that it follows the convention.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 10, 2026 20:45
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: eb9b116d-4091-496d-a248-28b0e3d33907

📥 Commits

Reviewing files that changed from the base of the PR and between ab46b0e and 8f8c138.

📒 Files selected for processing (3)
  • CLAUDE.md
  • traccar/README.md
  • traccar/docker-compose.yml
💤 Files with no reviewable changes (1)
  • traccar/docker-compose.yml

📝 Walkthrough

Walkthrough

This PR removes explicit dokploy-network declarations from the traccar service's compose file, allowing Dokploy to automatically attach its own network during deployment. Related documentation is updated to reflect this pattern.

Changes

Remove explicit Dokploy network from traccar

Layer / File(s) Summary
Compose file network cleanup
traccar/docker-compose.yml
The traccar service's networks attachment to dokploy-network is removed, and the top-level external network definition is also removed from the compose file.
Documentation updates
traccar/README.md, CLAUDE.md
The traccar README is updated to state that no explicit network is declared in the compose file and Dokploy auto-attaches a network on deploy. Architecture guidance in CLAUDE.md is updated to reflect this pattern for services that should omit explicit network declarations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • finallyjay/selfhosted-docker-services#31: The main PR updates traccar's compose/README to drop explicit dokploy-network attachments, matching the retrieved PR's CLAUDE.md convention that Dokploy auto-attaches dokploy-network for services that shouldn't declare custom networks (with traccar called out as a redundant legacy exception).

Poem

🐰 Networks once tangled, now set free,
Dokploy handles what the config used to be!
One less chain, one simpler way,
The docs now match, hooray, hooray! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description includes detailed changes and rationale but does not follow the repository's required template with 'Summary' and 'Test plan' sections. Structure the description using the repository template: add a 'Summary' section explaining what and why, and a 'Test plan' section describing how to verify the changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing redundant dokploy-network declarations from the traccar service configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch traccar-remove-redundant-network

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the traccar service with the repository’s documented Dokploy networking convention (from #31) by removing an explicit dokploy-network declaration that Dokploy auto-attaches at deploy time, and updating docs accordingly.

Changes:

  • Remove the redundant dokploy-network service-level and top-level network declarations from traccar/docker-compose.yml.
  • Update traccar/README.md to state that no network is declared and Dokploy attaches its network automatically.
  • Update CLAUDE.md to include traccar in the examples list for services that should not declare networks.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
traccar/docker-compose.yml Drops redundant explicit dokploy-network declarations to match Dokploy auto-network behavior.
traccar/README.md Updates the Networks section to reflect the no-explicit-network convention.
CLAUDE.md Refreshes the documented examples list to include traccar as convention-compliant.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@finallyjay finallyjay merged commit 959075e into main Jun 10, 2026
3 checks passed
@finallyjay finallyjay deleted the traccar-remove-redundant-network branch June 10, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants