Skip to content

Fix DBIx::Class ordered test CODE weaken GC stall #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fglock merged 1 commit into from
May 21, 2026
Merged

Fix DBIx::Class ordered test CODE weaken GC stall #787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/main/java/org/perlonjava/runtime/runtimetypes/WeakRefRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,17 +188,23 @@ public static void weaken(RuntimeScalar ref) {
ref.refCountOwned = false;
base.refCount = WEAKLY_TRACKED;
}
boolean shouldSweepLiveCodeRef = weakenedLiveCodeRef
boolean shouldCheckLiveCodeRef = weakenedLiveCodeRef
&& codeRefHasCountedOwners(base)
&& !ModuleInitGuard.inModuleInit();
if (base instanceof RuntimeCode code
&& code.refCount >= 0
&& weakRefsExist
&& (shouldSweepLiveCodeRef
&& (shouldCheckLiveCodeRef
|| (code.hadStashRef
&& code.stashRefCount <= 0
&& !isInstalledGlobalCodeRef(code)))) {
ReachabilityWalker.sweepWeakRefs(true);
// Keep this path targeted to the CODE referent. DBIC weakens
// callback CODE refs in hot cursor paths; running a full
// ReachabilityWalker sweep here forces repeated System.gc() calls.
// The CODE-specific stale-ref decision below is enough: live CODE
// refs are protected by clearWeakRefsTo()/shouldKeepCodeWeakRefs,
// while expired anonymous or former-stash CODE refs can still clear
// their weak registry entries immediately.
if (hasWeakRefsTo(code)
&& code.stashRefCount <= 0
&& !isInstalledGlobalCodeRef(code)
Expand Down
Loading